Bug 160474 - Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569
Summary: Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-02 16:07 PDT by Dean Jackson
Modified: 2016-08-26 11:21 PDT (History)
2 users (show)

See Also:

Attachments
Patch (45.78 KB, patch)
2016-08-02 16:15 PDT, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-08-02 16:07:11 PDT 
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569
Comment 1 Radar WebKit Bug Importer 2016-08-02 16:09:36 PDT 
<rdar://problem/27668170>
Comment 2 Dean Jackson 2016-08-02 16:09:50 PDT 
These fixes were fine, but they caused a regression on medium.com, and were reverted in http://trac.webkit.org/r203380
Comment 3 Radar WebKit Bug Importer 2016-08-02 16:10:05 PDT 
<rdar://problem/27668184>
Comment 4 Dean Jackson 2016-08-02 16:15:13 PDT 
Created attachment 285156 [details]
Patch
Comment 5 Simon Fraser (smfr) 2016-08-02 16:16:54 PDT 
Comment on attachment 285156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285156&action=review

> Source/WebCore/ChangeLog:13
> +        Now that we've branched, revert the reversion (which itself
> +        was a reversion), and then fix the actual bug.

Please make it clear that this change does not fix the bug.
Comment 6 Dean Jackson 2016-08-02 16:45:01 PDT 
Committed r204052: <http://trac.webkit.org/changeset/204052>
Comment 7 mitz 2016-08-02 16:57:19 PDT 
I don’t understand why we’re reintroducing these breaking changes. Nothing has changed since they were backed out. Seems like they should only be reintroduced once there is a plan to fix them.