Bug 160350 - Remove an unused line of code.
Summary: Remove an unused line of code.
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Depends on:
Blocks: 160344
  Show dependency treegraph
Reported: 2016-07-29 11:39 PDT by Mark Lam
Modified: 2016-07-29 11:49 PDT (History)
4 users (show)

See Also:

proposed patch. (1.79 KB, patch)
2016-07-29 11:43 PDT, Mark Lam
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-07-29 11:39:12 PDT
SVGInlineTextBox::paintText() instantiates a local variable selectionTextRun.

Thanks to analysis by Said Abou-Hallawa, we know that selectionTextRun was introduced in https://trac.webkit.org/changeset/61393, but was later rendered unused in https://trac.webkit.org/changeset/62099 because we switched to using paintTextWithShadows() with the selectionStyle.  Hence, selectionTextRun can be removed.
Comment 1 Mark Lam 2016-07-29 11:43:23 PDT
Created attachment 284877 [details]
proposed patch.
Comment 2 Mark Lam 2016-07-29 11:49:48 PDT
Thanks for the review.  Landed in r203910: <http://trac.webkit.org/r203910>.