WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
160350
Remove an unused line of code.
https://bugs.webkit.org/show_bug.cgi?id=160350
Summary
Remove an unused line of code.
Mark Lam
Reported
2016-07-29 11:39:12 PDT
SVGInlineTextBox::paintText() instantiates a local variable selectionTextRun. Thanks to analysis by Said Abou-Hallawa, we know that selectionTextRun was introduced in
https://trac.webkit.org/changeset/61393
, but was later rendered unused in
https://trac.webkit.org/changeset/62099
because we switched to using paintTextWithShadows() with the selectionStyle. Hence, selectionTextRun can be removed.
Attachments
proposed patch.
(1.79 KB, patch)
2016-07-29 11:43 PDT
,
Mark Lam
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2016-07-29 11:43:23 PDT
Created
attachment 284877
[details]
proposed patch.
Mark Lam
Comment 2
2016-07-29 11:49:48 PDT
Thanks for the review. Landed in
r203910
: <
http://trac.webkit.org/r203910
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug