Bug 160344 – Make StringView capable of being passed /returned in only 2 registers.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Mark Lam]

We just need to #if out copy and move constructors and assignment operators.

[Mark Lam]

Created attachment 284872 [details]
proposed patch.

[Geoffrey Garen]

Comment on attachment 284872 [details]
proposed patch.

/Volumes/Data/EWS/WebKit/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:615:13: error: unused variable 'selectionTextRun' [-Werror,-Wunused-variable]
    TextRun selectionTextRun = constructTextRun(selectionStyle, fragment);

[Mark Lam]

(In reply to comment #2)
> Comment on attachment 284872 [details]
> proposed patch.
> 
> /Volumes/Data/EWS/WebKit/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:
> 615:13: error: unused variable 'selectionTextRun' [-Werror,-Wunused-variable]
>     TextRun selectionTextRun = constructTextRun(selectionStyle, fragment);

Does not appear to be related to my patch at all.

[Geoffrey Garen]

Comment on attachment 284872 [details]
proposed patch.

r=me

[Mark Lam]

Comment on attachment 284872 [details]
proposed patch.

I'll land this manually later.

[Mark Lam]

Thanks for the review.  Landed in r203911: <http://trac.webkit.org/r203911>.

[Darin Adler]

Thanks, Mark. This is great!

[Mark Lam]

Follow up build fix in r203915: <http://trac.webkit.org/r203915>.

[Radar WebKit Bug Importer]

<rdar://problem/27613944>

[Alexey Proskuryakov]

> #if defined(NDEBUG) || COMPILER(MSVC) || 1
> #define CHECK_STRINGVIEW_LIFETIME 0

This is pre-existing code, however I'm curious anyway - is there a bug tracking re-enabling the checks?

[Darin Adler]

Wow, did not realize these were turned off. Do we know exactly when we turned them off and why? Should find out when that || 1 was added.

[Mark Lam]

(In reply to comment #11)
> Wow, did not realize these were turned off. Do we know exactly when we
> turned them off and why? Should find out when that || 1 was added.

See https://trac.webkit.org/changeset/174397 from Oct 2014.

(In reply to comment #10)
> This is pre-existing code, however I'm curious anyway - is there a bug
> tracking re-enabling the checks?

Apparently, no.

[Mark Lam]

Will work on re-enabling the StringView life-cycle checks in https://bugs.webkit.org/show_bug.cgi?id=160384.