Bug 160101 - [mac-wk1] LayoutTest userscripts/window-onerror-for-isolated-world-3.html is a flaky failure
Summary: [mac-wk1] LayoutTest userscripts/window-onerror-for-isolated-world-3.html is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-22 14:50 PDT by Ryan Haddad
Modified: 2023-10-10 11:41 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-07-22 14:50:17 PDT
LayoutTest userscripts/window-onerror-for-isolated-world-3.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r203611%20(6878)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=userscripts%2Fwindow-onerror-for-isolated-world-3.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/userscripts/window-onerror-for-isolated-world-3-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/userscripts/window-onerror-for-isolated-world-3-actual.txt
@@ -8,12 +8,11 @@
 Main world error event listener: [object Window] at undefined:0:0 null
 
 Main World
+Isolated World
 Main world window.onerror: SerializableError from (main world) at window-onerror-for-isolated-world-3.html:49:59 SerializableError from (main world)
 Main world error event listener: SerializableError from (main world) at window-onerror-for-isolated-world-3.html:49:59 SerializableError from (main world)
 Main world window.onerror: [object Window] at window-onerror-for-isolated-world-3.html:55:27 [object Window]
 Main world error event listener: [object Window] at window-onerror-for-isolated-world-3.html:55:27 [object Window]
-
-Isolated World
 Main world window.onerror: SerializableError from (isolated script) at window-onerror-for-isolated-world-3.html:5:59 SerializableError from (isolated script)
 Main world error event listener: SerializableError from (isolated script) at window-onerror-for-isolated-world-3.html:5:59 SerializableError from (isolated script)
 Main world window.onerror: [object Window] at window-onerror-for-isolated-world-3.html:11:27 null
Comment 1 Ryan Haddad 2016-07-22 15:02:46 PDT
Marked as flaky in https://trac.webkit.org/r203617

Prior attempt at fixing this can be seen in https://bugs.webkit.org/show_bug.cgi?id=158750
Comment 2 Ben Schwartz 2023-09-13 22:37:37 PDT
This test appears to have further regressed into a constant failure.

HISTORY:

https://results.webkit.org/?suite=layout-tests&test=userscripts%2Fwindow-onerror-for-isolated-world-3.html

TEXT DIFF:

 User Script
 Main world window.onerror: SerializableError from (user script) at :5:59 SerializableError from (user script)
 Main world error event listener: SerializableError from (user script) at :5:59 SerializableError from (user script)
-Main world window.onerror: [object Window] at undefined:0:0 null
-Main world error event listener: [object Window] at undefined:0:0 null
+Main world window.onerror: [object Window] at :11:27 null
+Main world error event listener: [object Window] at :11:27 null
 
 Main World
 Main world window.onerror: SerializableError from (main world) at window-onerror-for-isolated-world-3.html:49:59 SerializableError from (main world)

DIFF URL:

https://build.webkit.org/results/Apple-Monterey-Debug-AppleSilicon-WK1-Tests/267976@main%20(8521)/userscripts/window-onerror-for-isolated-world-3-pretty-diff.html

REPRODUCTION:

I was able to reproduce this issue on macOS Ventura (13.5, 22G74/arm64) ToT using the following command:

run-webkit-tests -1 --verbose --clobber-old-results userscripts/window-onerror-for-isolated-world-3.html

REGRESSION:

I was unable to locate a regression point, as the issue began before the earliest entry in the flakiness dashboard.
Comment 3 Radar WebKit Bug Importer 2023-09-13 22:38:08 PDT
<rdar://problem/115472137>
Comment 4 Chris Dumez 2023-10-10 09:09:41 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18894
Comment 5 EWS 2023-10-10 11:41:32 PDT
Committed 269158@main (036e5c39e5e1): <https://commits.webkit.org/269158@main>

Reviewed commits have been landed. Closing PR #18894 and removing active labels.