Bug 158750 - [mac-wk1 debug] LayoutTest userscripts/window-onerror-for-isolated-world-3.html is flaky
Summary: [mac-wk1 debug] LayoutTest userscripts/window-onerror-for-isolated-world-3.ht...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-14 13:25 PDT by Ryan Haddad
Modified: 2016-07-22 15:00 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.44 KB, patch)
2016-06-14 13:30 PDT, Ryan Haddad
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-06-14 13:25:24 PDT
LayoutTest userscripts/window-onerror-for-isolated-world-3.html is flaky

<https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/5940>

<https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=userscripts%2Fwindow-onerror-for-isolated-world-3.html>

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/userscripts/window-onerror-for-isolated-world-3-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/userscripts/window-onerror-for-isolated-world-3-actual.txt
@@ -8,12 +8,11 @@
 Main world error event listener: [object Window] at undefined:0:0 null
 
 Main World
+Isolated World
 Main world window.onerror: SerializableError from (main world) at window-onerror-for-isolated-world-3.html:49:59 SerializableError from (main world)
 Main world error event listener: SerializableError from (main world) at window-onerror-for-isolated-world-3.html:49:59 SerializableError from (main world)
 Main world window.onerror: [object Window] at window-onerror-for-isolated-world-3.html:55:27 [object Window]
 Main world error event listener: [object Window] at window-onerror-for-isolated-world-3.html:55:27 [object Window]
-
-Isolated World
 Main world window.onerror: SerializableError from (isolated script) at window-onerror-for-isolated-world-3.html:5:59 SerializableError from (isolated script)
 Main world error event listener: SerializableError from (isolated script) at window-onerror-for-isolated-world-3.html:5:59 SerializableError from (isolated script)
 Main world window.onerror: [object Window] at window-onerror-for-isolated-world-3.html:11:27 null
Comment 1 Joseph Pecoraro 2016-06-14 13:25:52 PDT
Let me bump up the timeouts just a tad.
Comment 2 Ryan Haddad 2016-06-14 13:30:48 PDT
Created attachment 281275 [details]
Patch
Comment 3 Joseph Pecoraro 2016-06-14 13:32:11 PDT
Comment on attachment 281275 [details]
Patch

r=me!
Comment 4 Ryan Haddad 2016-06-14 13:33:47 PDT
Comment on attachment 281275 [details]
Patch

Clearing flags on attachment: 281275

Committed r202061: <http://trac.webkit.org/changeset/202061>
Comment 5 Ryan Haddad 2016-06-14 13:33:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2016-06-14 13:40:03 PDT
Is there any way to avoid having timeouts in the normal execution path? It is normal for a regression test to stall for a couple seconds, so doubling a timeout is not a reliable fix.
Comment 7 Joseph Pecoraro 2016-06-14 13:55:17 PDT
Yes, it could be possible with more hardcoding of expected messages.

  Expect 4 messages => advance()
  Expect 4 messages => advance()
  Expect 4 messages => advance() => end