Bug 160071 – Parameter to Node.compareDocumentPosition() should be mandatory and non-nullable

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Parameter to Node.compareDocumentPosition() should be mandatory and non-nullable:
- https://dom.spec.whatwg.org/#interface-node

Firefox and Chrome agree with the specification.

[Chris Dumez]

Created attachment 284306 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 284306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284306&action=review

> Source/WebCore/ChangeLog:8
> +
> +        

What's up with the second blank line (with leading whitespace)?

[Chris Dumez]

Comment on attachment 284306 [details]
Patch

Clearing flags on attachment: 284306

Committed r203601: <http://trac.webkit.org/changeset/203601>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 284306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284306&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:649
> -    if (afterRange && ((afterRange->startPosition().anchorNode()->compareDocumentPosition(referenceRange->endPosition().anchorNode()) & Node::DOCUMENT_POSITION_DISCONNECTED) == Node::DOCUMENT_POSITION_DISCONNECTED))
> +    if (afterRange && (referenceRange->endPosition().isNull() || ((afterRange->startPosition().anchorNode()->compareDocumentPosition(*referenceRange->endPosition().anchorNode()) & Node::DOCUMENT_POSITION_DISCONNECTED) == Node::DOCUMENT_POSITION_DISCONNECTED)))

Sure seems like a wordy way to write this. If "b" is a single bit, then in a boolean context:

    (x & b) == b

Is just a wordy way to write:

    (x & b)