Bug 164093 - Regression(r203601): Caused crashes in iBooks
Summary: Regression(r203601): Caused crashes in iBooks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 160071
  Show dependency tree / graph
 
Reported: 2016-10-27 16:30 PDT by Chris Dumez
Modified: 2016-10-27 20:58 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2016-10-27 16:34 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (8.74 KB, patch)
2016-10-27 17:04 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-27 16:30:31 PDT 
r203601 caused crashes in iBooks.

The change made the parameter non-nullable. In ObjC bindings, the approach at the time was to throw an exception (and therefore crash) when passing nil.
Comment 1 Chris Dumez 2016-10-27 16:31:01 PDT 
<rdar://problem/28745634>
Comment 2 Chris Dumez 2016-10-27 16:34:42 PDT 
Created attachment 293076 [details]
Patch
Comment 3 Chris Dumez 2016-10-27 17:04:16 PDT 
Created attachment 293081 [details]
Patch
Comment 4 WebKit Commit Bot 2016-10-27 20:58:46 PDT 
Comment on attachment 293081 [details]
Patch

Clearing flags on attachment: 293081

Committed r208027: <http://trac.webkit.org/changeset/208027>
Comment 5 WebKit Commit Bot 2016-10-27 20:58:51 PDT 
All reviewed patches have been landed.  Closing bug.