Bug 159990 - REGRESSION(r148588): ews classes might get garbage collected
Summary: REGRESSION(r148588): ews classes might get garbage collected
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-20 15:54 PDT by Aakash Jain
Modified: 2016-07-20 17:29 PDT (History)
6 users (show)

See Also:

Attachments
Proposed patch (1.14 KB, patch)
2016-07-20 16:06 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2016-07-20 15:54:28 PDT 
sometimes running webkit-patch command for ews queues fails with below error.

buildbot$ ./Tools/Scripts/webkit-patch ios-ews --bot-id=bot110 --exit-after-iteration 1
Usage: webkit-patch [options] COMMAND [ARGS]

webkit-patch: error: no such option: --exit-after-iteration


It happens because webkit-patch sometimes do not know about ews classes. This happens because AbstractEarlyWarningSystem.load_ews_classes() is called in webkitpy/tool/commands/__init__.py, but the result is not stored in a variable and it might get garbage collected.
Comment 1 Aakash Jain 2016-07-20 16:05:44 PDT 
This issue got exposed by a recent commit <http://trac.webkit.org/r203386>, and we did a temporary fix  <http://trac.webkit.org/r203417>.
Comment 2 Aakash Jain 2016-07-20 16:06:07 PDT 
Created attachment 284162 [details]
Proposed patch
Comment 3 WebKit Commit Bot 2016-07-20 16:29:20 PDT 
Comment on attachment 284162 [details]
Proposed patch

Clearing flags on attachment: 284162

Committed r203479: <http://trac.webkit.org/changeset/203479>
Comment 4 WebKit Commit Bot 2016-07-20 16:29:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2016-07-20 17:08:56 PDT 
Comment on attachment 284162 [details]
Proposed patch

Aakash, could you please revert the temporary fix?
Comment 6 Aakash Jain 2016-07-20 17:28:23 PDT 
sure, reverting it in https://bugs.webkit.org/show_bug.cgi?id=160001