Bug 114558 - Isolate Early Warning System definitions into a JSON
Summary: Isolate Early Warning System definitions into a JSON
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 114669 114737
Blocks: 114564
  Show dependency tree / graph
 
Reported: 2013-04-13 03:13 PDT by Ryosuke Niwa
Modified: 2016-07-20 15:56 PDT (History)
7 users (show)

See Also:

Attachments
Adds ews.json (9.36 KB, patch)
2013-04-13 03:16 PDT, Ryosuke Niwa 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-04-13 03:13:29 PDT 
Isolate Early Warning System defintions into a JSON
Comment 1 Ryosuke Niwa 2013-04-13 03:16:45 PDT 
Created attachment 197930 [details]
Adds ews.json
Comment 2 Benjamin Poulain 2013-04-13 21:56:05 PDT 
Comment on attachment 197930 [details]
Adds ews.json

View in context: https://bugs.webkit.org/attachment.cgi?id=197930&action=review

> Tools/ChangeLog:3
> +        Isolate Early Warning System defintions into a JSON

Typo: defintions

> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:155
> +                'run_tests': config.get('runTests', False),

cls.run_tests?
Comment 3 Alan Cutter 2013-04-14 07:02:20 PDT 
I'm glad to see this change to the EWS, any plans for the QueueStatusServer to use the same data?
Comment 4 Ryosuke Niwa 2013-04-16 00:42:32 PDT 
Committed r148498: <http://trac.webkit.org/changeset/148498>
Comment 5 WebKit Commit Bot 2013-04-16 01:21:17 PDT 
Re-opened since this is blocked by bug 114669
Comment 6 Ryosuke Niwa 2013-04-16 18:40:15 PDT 
Committed r148588: <http://trac.webkit.org/changeset/148588>
Comment 7 Csaba Osztrogonác 2013-04-17 06:16:07 PDT 
Comment on attachment 197930 [details]
Adds ews.json

View in context: https://bugs.webkit.org/attachment.cgi?id=197930&action=review

> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:152
> +                'name': config['port'] + '-ews',

This change killed the Qt WK2 EWS, because the port is qt, but its name should be qt-wk2-ews.
Comment 8 Csaba Osztrogonác 2013-04-17 06:41:49 PDT 
Fix is coming soon in https://bugs.webkit.org/show_bug.cgi?id=114737