Fix null handling of HTMLMediaElement.mediaGroup to match the specification: - https://www.w3.org/TR/html5/embedded-content-0.html#media-elements null is supposed to be treated as the String "null".
Created attachment 284124 [details] Patch
Comment on attachment 284124 [details] Patch Attachment 284124 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1715032 New failing tests: imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
Created attachment 284129 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5
(In reply to comment #3) > Created attachment 284129 [details] > Archive of layout-test-results from ews126 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5 ios has its own baseline. I'll rebaseline for iOS before landing.
Committed r203463: <http://trac.webkit.org/changeset/203463>
Comment on attachment 284124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284124&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:-4455 > - return ("valueToStringWithNullCheck(state, $value)", 1) if $signature->extendedAttributes->{"TreatNullAs"} eq "LegacyNullString"; What about valueToStringWithNullCheck? Is that function still used anywhere?
(In reply to comment #6) > Comment on attachment 284124 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284124&action=review > > > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:-4455 > > - return ("valueToStringWithNullCheck(state, $value)", 1) if $signature->extendedAttributes->{"TreatNullAs"} eq "LegacyNullString"; > > What about valueToStringWithNullCheck? Is that function still used anywhere? Yes, in a couple of places. I am working on killing it though: -> https://bugs.webkit.org/show_bug.cgi?id=159984 and another patch coming soon.
(In reply to comment #7) > (In reply to comment #6) > > Comment on attachment 284124 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=284124&action=review > > > > > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:-4455 > > > - return ("valueToStringWithNullCheck(state, $value)", 1) if $signature->extendedAttributes->{"TreatNullAs"} eq "LegacyNullString"; > > > > What about valueToStringWithNullCheck? Is that function still used anywhere? > > Yes, in a couple of places. I am working on killing it though: > -> https://bugs.webkit.org/show_bug.cgi?id=159984 > and another patch coming soon. and https://bugs.webkit.org/show_bug.cgi?id=159982