Bug 159984 - Get rid of custom bindings code for XMLHttpRequest.open()
Summary: Get rid of custom bindings code for XMLHttpRequest.open()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://xhr.spec.whatwg.org/#xmlhttpr...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-20 13:46 PDT by Chris Dumez
Modified: 2016-07-20 15:04 PDT (History)
8 users (show)

See Also:

Attachments
Patch (7.29 KB, patch)
2016-07-20 14:08 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-20 13:46:22 PDT 
Get rid of custom bindings code for XMLHttpRequest.open() as the bindings generator is able to generate it.

Relevant specification:
- https://xhr.spec.whatwg.org/#xmlhttprequest

The issue is that legacy content prevents treating the 'async' argument being undefined identical from it being omitted. However, this can be achieved by using overloading in IDL, like in the specification.
Comment 1 Chris Dumez 2016-07-20 14:08:11 PDT 
Created attachment 284147 [details]
Patch
Comment 2 Chris Dumez 2016-07-20 15:04:35 PDT 
Comment on attachment 284147 [details]
Patch

Clearing flags on attachment: 284147

Committed r203470: <http://trac.webkit.org/changeset/203470>
Comment 3 Chris Dumez 2016-07-20 15:04:40 PDT 
All reviewed patches have been landed.  Closing bug.