Bug 159524 – Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Let's force all tests to run with a smaller JS stack size than the default 4M.  This will help stack overflow tests to run faster.

The actual size to use is TBD.  Currently, it's looking like 384KB.  Continuing to test.

[Mark Lam]

I end up going with 1.5M and fixing some tests to behave better.

[Mark Lam]

Created attachment 283202 [details]
proposed patch.

[Michael Saboff]

Comment on attachment 283202 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=283202&action=review

r=me
Did you check 1.5M stack on all the platforms you can test on?

> LayoutTests/js/script-tests/stack-overflow-arrity-catch.js:8
>  function funcWith20Args(arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8,
>                          arg9, arg10, arg11, arg12, arg13, arg14, arg15,
> -                        arg16, arg17, arg18, arg19, arg20)
> +                        arg16, arg17, arg18, arg19, arg20,
> +                        arg21, arg22, arg23, arg24, arg25, arg26, arg27, arg28,
> +                        arg29, arg30, arg31, arg32, arg33, arg34, arg35,
> +                        arg36, arg37, arg38, arg39, arg40)

You should change the name of the function.

[Mark Lam]

(In reply to comment #3)
> Comment on attachment 283202 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=283202&action=review
> 
> r=me
> Did you check 1.5M stack on all the platforms you can test on?

I only tested on x86_64, but I think the 1.5M size should be reasonable.  I wasn't cutting it too close.  I'll wait till Monday morning before landing so that we can see what the bots say, and respond accordingly.
 
> > LayoutTests/js/script-tests/stack-overflow-arrity-catch.js:8
> >  function funcWith20Args(arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8,
> >                          arg9, arg10, arg11, arg12, arg13, arg14, arg15,
> > -                        arg16, arg17, arg18, arg19, arg20)
> > +                        arg16, arg17, arg18, arg19, arg20,
> > +                        arg21, arg22, arg23, arg24, arg25, arg26, arg27, arg28,
> > +                        arg29, arg30, arg31, arg32, arg33, arg34, arg35,
> > +                        arg36, arg37, arg38, arg39, arg40)
> 
> You should change the name of the function.

Fixed.  Thanks.

[Mark Lam]

Created attachment 283206 [details]
patch for landing.

[Mark Lam]

Landed in r203067: <http://trac.webkit.org/r203067>.