Bug 159518 - td / th should be exposed as HTMLTableCellElement objects
Summary: td / th should be exposed as HTMLTableCellElement objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar, WebExposed
Depends on:
Blocks: 148859
  Show dependency treegraph
 
Reported: 2016-07-07 11:06 PDT by Chris Dumez
Modified: 2016-07-07 15:37 PDT (History)
4 users (show)

See Also:


Attachments
Patch (41.75 KB, patch)
2016-07-07 12:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.06 MB, application/zip)
2016-07-07 13:18 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews101 for mac-yosemite (845.74 KB, application/zip)
2016-07-07 13:18 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews113 for mac-yosemite (1.58 MB, application/zip)
2016-07-07 13:23 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (588.34 KB, application/zip)
2016-07-07 13:27 PDT, Build Bot
no flags Details
Patch (48.63 KB, patch)
2016-07-07 13:43 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (827.30 KB, application/zip)
2016-07-07 14:39 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (830.99 KB, application/zip)
2016-07-07 14:42 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews116 for mac-yosemite (1.46 MB, application/zip)
2016-07-07 14:49 PDT, Build Bot
no flags Details
Patch (53.73 KB, patch)
2016-07-07 14:56 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-07 11:06:41 PDT
td / th should be exposed as HTMLTableCellElement objects:
- https://html.spec.whatwg.org/multipage/tables.html#the-td-element
- https://html.spec.whatwg.org/multipage/tables.html#the-th-element

We currently have HTMLTableDataCellElement / HTMLTableHeaderCellElement sub-types.

Firefox and Chrome match the current specification.

We actually introduced these types recently via Bug 148859 to align with an older version of the HTML specification. However, it seems the specification has been updated to match Firefox / Chrome in the mean time.

Since we have not shipped those subtypes yet, the compatibility risk is low.
Comment 1 Radar WebKit Bug Importer 2016-07-07 11:07:29 PDT
<rdar://problem/27225436>
Comment 2 Chris Dumez 2016-07-07 12:21:37 PDT
Created attachment 283035 [details]
Patch
Comment 3 Build Bot 2016-07-07 13:18:03 PDT
Comment on attachment 283035 [details]
Patch

Attachment 283035 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1642559

New failing tests:
fast/dom/wrapper-classes.html
js/dom/global-constructors-attributes.html
Comment 4 Build Bot 2016-07-07 13:18:07 PDT
Created attachment 283036 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-07-07 13:18:35 PDT
Comment on attachment 283035 [details]
Patch

Attachment 283035 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1642566

New failing tests:
fast/dom/wrapper-classes.html
js/dom/global-constructors-attributes.html
Comment 6 Build Bot 2016-07-07 13:18:38 PDT
Created attachment 283037 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-07-07 13:23:47 PDT
Comment on attachment 283035 [details]
Patch

Attachment 283035 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1642562

New failing tests:
fast/dom/wrapper-classes.html
js/dom/global-constructors-attributes.html
Comment 8 Build Bot 2016-07-07 13:23:50 PDT
Created attachment 283038 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2016-07-07 13:27:25 PDT
Comment on attachment 283035 [details]
Patch

Attachment 283035 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1642576

New failing tests:
imported/w3c/web-platform-tests/html/semantics/interfaces.html
fast/dom/wrapper-classes.html
Comment 10 Build Bot 2016-07-07 13:27:28 PDT
Created attachment 283039 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 11 Chris Dumez 2016-07-07 13:43:32 PDT
Created attachment 283041 [details]
Patch
Comment 12 Build Bot 2016-07-07 14:39:45 PDT
Comment on attachment 283041 [details]
Patch

Attachment 283041 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1642880

New failing tests:
js/dom/global-constructors-attributes.html
Comment 13 Build Bot 2016-07-07 14:39:48 PDT
Created attachment 283051 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 14 Build Bot 2016-07-07 14:42:46 PDT
Comment on attachment 283041 [details]
Patch

Attachment 283041 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1642883

New failing tests:
js/dom/global-constructors-attributes.html
Comment 15 Build Bot 2016-07-07 14:42:50 PDT
Created attachment 283052 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 16 Build Bot 2016-07-07 14:49:18 PDT
Comment on attachment 283041 [details]
Patch

Attachment 283041 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1642889

New failing tests:
js/dom/global-constructors-attributes.html
Comment 17 Build Bot 2016-07-07 14:49:22 PDT
Created attachment 283053 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 18 Chris Dumez 2016-07-07 14:56:54 PDT
Created attachment 283055 [details]
Patch
Comment 19 Chris Dumez 2016-07-07 15:37:20 PDT
Comment on attachment 283055 [details]
Patch

Clearing flags on attachment: 283055

Committed r202937: <http://trac.webkit.org/changeset/202937>
Comment 20 Chris Dumez 2016-07-07 15:37:26 PDT
All reviewed patches have been landed.  Closing bug.