Bug 148859 - td and th should use HTMLTableDataCellElement and HTMLTableHeaderCellElement interfaces
Summary: td and th should use HTMLTableDataCellElement and HTMLTableHeaderCellElement ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
: 111469 (view as bug list)
Depends on: 159518
Blocks:
  Show dependency tree / graph
 
Reported: 2015-09-04 17:27 PDT by Ryosuke Niwa
Modified: 2016-07-07 11:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (75.30 KB, patch)
2015-10-16 20:42 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (75.36 KB, patch)
2015-10-17 11:33 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (68.42 KB, patch)
2015-10-17 11:50 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-09-04 17:27:12 PDT 
See
https://html.spec.whatwg.org/multipage/tables.html#htmltabledatacellelement
https://html.spec.whatwg.org/multipage/tables.html#the-th-element

td and th elements should use HTMLTableDataCellElement and HTMLTableHeaderCellElement interfaces respectively.

This bug was found by the newly added test:
LayoutTests/http/tests/w3c/html/semantics/interfaces.html
Comment 1 Radar WebKit Bug Importer 2015-09-04 17:28:04 PDT 
<rdar://problem/22588664>
Comment 2 Chris Dumez 2015-10-16 16:38:00 PDT 
*** Bug 111469 has been marked as a duplicate of this bug. ***
Comment 3 Chris Dumez 2015-10-16 20:42:07 PDT 
Created attachment 263357 [details]
Patch
Comment 4 Ryosuke Niwa 2015-10-17 10:38:15 PDT 
Comment on attachment 263357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263357&action=review

> Source/WebCore/html/HTMLTableDataCellElement.idl:27
> +    // Legacy.

This is legacy in the sense that we're keeping these for WebKit-specific compatibility reasons, right?
We should explicitly say that.
Comment 5 Chris Dumez 2015-10-17 10:58:07 PDT 
(In reply to comment #4)
> Comment on attachment 263357 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=263357&action=review
> 
> > Source/WebCore/html/HTMLTableDataCellElement.idl:27
> > +    // Legacy.
> 
> This is legacy in the sense that we're keeping these for WebKit-specific
> compatibility reasons, right?
> We should explicitly say that.

Yes, the spec does not have these attributes on HTMLTableDataCellElement but I kept them for backward compatibility. I'll clarify the comment before landing, thanks.
Comment 6 Chris Dumez 2015-10-17 11:33:49 PDT 
Created attachment 263379 [details]
Patch
Comment 7 WebKit Commit Bot 2015-10-17 11:36:25 PDT 
Comment on attachment 263379 [details]
Patch

Rejecting attachment 263379 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 263379, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
hing file LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt
patching file LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
patching file LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
patching file LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/301029
Comment 8 Chris Dumez 2015-10-17 11:50:37 PDT 
Created attachment 263381 [details]
Patch
Comment 9 WebKit Commit Bot 2015-10-17 12:38:50 PDT 
Comment on attachment 263381 [details]
Patch

Clearing flags on attachment: 263381

Committed r191247: <http://trac.webkit.org/changeset/191247>
Comment 10 WebKit Commit Bot 2015-10-17 12:38:55 PDT 
All reviewed patches have been landed.  Closing bug.