Bug 148859 – td and th should use HTMLTableDataCellElement and HTMLTableHeaderCellElement interfaces

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

See
https://html.spec.whatwg.org/multipage/tables.html#htmltabledatacellelement
https://html.spec.whatwg.org/multipage/tables.html#the-th-element

td and th elements should use HTMLTableDataCellElement and HTMLTableHeaderCellElement interfaces respectively.

This bug was found by the newly added test:
LayoutTests/http/tests/w3c/html/semantics/interfaces.html

[Radar WebKit Bug Importer]

<rdar://problem/22588664>

[Chris Dumez]

*** Bug 111469 has been marked as a duplicate of this bug. ***

[Chris Dumez]

Created attachment 263357 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 263357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263357&action=review

> Source/WebCore/html/HTMLTableDataCellElement.idl:27
> +    // Legacy.

This is legacy in the sense that we're keeping these for WebKit-specific compatibility reasons, right?
We should explicitly say that.

[Chris Dumez]

(In reply to comment #4)
> Comment on attachment 263357 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=263357&action=review
> 
> > Source/WebCore/html/HTMLTableDataCellElement.idl:27
> > +    // Legacy.
> 
> This is legacy in the sense that we're keeping these for WebKit-specific
> compatibility reasons, right?
> We should explicitly say that.

Yes, the spec does not have these attributes on HTMLTableDataCellElement but I kept them for backward compatibility. I'll clarify the comment before landing, thanks.

[Chris Dumez]

Created attachment 263379 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 263379 [details]
Patch

Rejecting attachment 263379 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 263379, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
hing file LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt
patching file LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
patching file LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
patching file LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/301029

[Chris Dumez]

Created attachment 263381 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 263381 [details]
Patch

Clearing flags on attachment: 263381

Committed r191247: <http://trac.webkit.org/changeset/191247>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.