Bug 159465 – [GTK][Threaded Compositor] Web view background colors don't work

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Bug #159455 makes them work for GTK+ when not using the threaded compositor, but it's not enough for the threaded compositor.

[Carlos Garcia Campos]

Created attachment 283004 [details]
Patch

[Michael Catanzaro]

Comment on attachment 283004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283004&action=review

> Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:87
> +        m_drawsBackground = drawsBackground;

This is fine as it is, but my style is to capture only protectedThis and use it explicitly in the lambda, instead of capturing both this and protectedThis. I'm not sure which style is more prevalent in WebKit code.

[Carlos Garcia Campos]

(In reply to comment #2)
> Comment on attachment 283004 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=283004&action=review
> 
> > Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:87
> > +        m_drawsBackground = drawsBackground;
> 
> This is fine as it is, but my style is to capture only protectedThis and use
> it explicitly in the lambda, instead of capturing both this and
> protectedThis. I'm not sure which style is more prevalent in WebKit code.

There's no consensus last time we discussed it, some people (like me) prefer to also capture this to make the lambda body easier to read without having to use protectedThis-> everywhere.

[Carlos Garcia Campos]

Committed r203497: <http://trac.webkit.org/changeset/203497>