Bug 159455 – [GTK] Web view background colors don't work in accelerated compositing mode

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

This can be easily tested with MiniBrowser, for example:

$ WEBKIT_FORCE_COMPOSITING_MODE=1 MiniBrowser --bg-color="rgba(255, 0, 0, 0.70)" -e

The background is opaque white, and there are artifacts when resizing the window (because the web process is not rendering backgrounds when setting a web view bg color). This needs changes in the UI process when using the redirected window, but also in the web process. And of course it always happens with the threaded compositor when ACC mode is always enabled.

[Carlos Garcia Campos]

Created attachment 282882 [details]
Patch

This needs patch attached to bug #159463

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Michael Catanzaro]

Comment on attachment 282882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282882&action=review

The compatibility issue should be mentioned when you prepare release notes for 2.14.

> Source/WebKit2/ChangeLog:12
> +        window has an RGBA visual, even when setting a fully opaque brakcground, because we still need the web process

background

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3519
> + * #GtkWidget:app-paintable property set to %TRUE, for backgrounds colors to work.

Get rid of this comma.

> Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:192
> +    xDamageNotifier().add(m_window.get(), [this, damageNotify = WTFMove(damageNotify)] {

Is it normal WebKit style to put spaces around the assignment operator here? I think it's easier to read without spaces.

[Carlos Garcia Campos]

(In reply to comment #3)
> Comment on attachment 282882 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282882&action=review
> 
> The compatibility issue should be mentioned when you prepare release notes
> for 2.14.
> 
> > Source/WebKit2/ChangeLog:12
> > +        window has an RGBA visual, even when setting a fully opaque brakcground, because we still need the web process
> 
> background
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3519
> > + * #GtkWidget:app-paintable property set to %TRUE, for backgrounds colors to work.
> 
> Get rid of this comma.
> 
> > Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:192
> > +    xDamageNotifier().add(m_window.get(), [this, damageNotify = WTFMove(damageNotify)] {
> 
> Is it normal WebKit style to put spaces around the assignment operator here?
> I think it's easier to read without spaces.

Yes.

[Carlos Garcia Campos]

(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 282882 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=282882&action=review
> > 
> > The compatibility issue should be mentioned when you prepare release notes
> > for 2.14.
> > 
> > > Source/WebKit2/ChangeLog:12
> > > +        window has an RGBA visual, even when setting a fully opaque brakcground, because we still need the web process
> > 
> > background
> > 
> > > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3519
> > > + * #GtkWidget:app-paintable property set to %TRUE, for backgrounds colors to work.
> > 
> > Get rid of this comma.
> > 
> > > Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:192
> > > +    xDamageNotifier().add(m_window.get(), [this, damageNotify = WTFMove(damageNotify)] {
> > 
> > Is it normal WebKit style to put spaces around the assignment operator here?
> > I think it's easier to read without spaces.
> 
> Yes.

Yes, that it's normal webkit style, I don't think removing the spaces makes it easier to read ta all.

[Carlos Garcia Campos]

Committed r203496: <http://trac.webkit.org/changeset/203496>

*** Bug 158153 has been marked as a duplicate of this bug. ***