Bug 159394 - webkit-patch failure-reason always raises TypeError
Summary: webkit-patch failure-reason always raises TypeError
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-03 23:21 PDT by Fujii Hironori
Modified: 2016-07-04 01:06 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2016-07-03 23:34 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2016-07-03 23:21:06 PDT
>  $ ./Tools/Scripts/webkit-patch failure-reason
> Auto-installing package: mechanize
> Traceback (most recent call last):
>   File "./Tools/Scripts/webkit-patch", line 84, in <module>
>     main()
>   File "./Tools/Scripts/webkit-patch", line 79, in main
>     WebKitPatch(os.path.abspath(__file__)).main()
>   File "/home/fujii/work/webkit/git/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
>     result = command.check_arguments_and_execute(options, args, self)
>   File "/home/fujii/work/webkit/git/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
>     return self.execute(options, args, tool) or 0
>   File "/home/fujii/work/webkit/git/Tools/Scripts/webkitpy/tool/commands/queries.py", line 334, in execute
>     (builder, latest_revision) = self._builder_to_explain()
>   File "/home/fujii/work/webkit/git/Tools/Scripts/webkitpy/tool/commands/queries.py", line 318, in _builder_to_explain
>     print "%s failing" % (pluralize("builder", len(red_statuses)))
>   File "/home/fujii/work/webkit/git/Tools/Scripts/webkitpy/tool/grammar.py", line 43, in pluralize
>     noun = plural(noun)
>   File "/home/fujii/work/webkit/git/Tools/Scripts/webkitpy/tool/grammar.py", line 35, in plural
>     if re.search("h$", noun):
>   File "/usr/lib/python2.7/re.py", line 146, in search
>     return _compile(pattern, flags).search(string)
> TypeError: expected string or buffer
>  $


In r170637 (Bug 133067), the first and second arguments of pluralize were swapped.
Comment 1 Fujii Hironori 2016-07-03 23:34:57 PDT
Created attachment 282683 [details]
Patch
Comment 2 Benjamin Poulain 2016-07-04 00:46:40 PDT
Comment on attachment 282683 [details]
Patch

Thanks for fixing this.
Comment 3 WebKit Commit Bot 2016-07-04 01:06:37 PDT
Comment on attachment 282683 [details]
Patch

Clearing flags on attachment: 282683

Committed r202804: <http://trac.webkit.org/changeset/202804>
Comment 4 WebKit Commit Bot 2016-07-04 01:06:41 PDT
All reviewed patches have been landed.  Closing bug.