Bug 133067 - [webkitpy] Refactor pluralizer in grammar.py
Summary: [webkitpy] Refactor pluralizer in grammar.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-19 02:33 PDT by Éva Balázsfalvi
Modified: 2014-07-01 06:10 PDT (History)
9 users (show)

See Also:

Attachments
Patch (27.04 KB, patch)
2014-05-28 02:20 PDT, Éva Balázsfalvi 		ossy: review+
ossy: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (632.43 KB, application/zip)
2014-05-28 03:23 PDT, Build Bot 		no flags Details
patch for landing (26.64 KB, patch)
2014-07-01 04:07 PDT, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
patch for landing (25.12 KB, patch)
2014-07-01 04:17 PDT, Éva Balázsfalvi 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch for landing (25.12 KB, patch)
2014-07-01 05:20 PDT, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Éva Balázsfalvi 2014-05-19 02:33:00 PDT 
Refactor pluralizer in Tools/Scripts/webkitpy/tool/grammar.py and use
it everywhere, for example in
Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py
Comment 1 Éva Balázsfalvi 2014-05-28 02:20:45 PDT 
Created attachment 232180 [details]
Patch
Comment 2 Build Bot 2014-05-28 03:22:59 PDT 
Comment on attachment 232180 [details]
Patch

Attachment 232180 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5138742662660096

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 3 Build Bot 2014-05-28 03:23:01 PDT 
Created attachment 232186 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Éva Balázsfalvi 2014-05-29 01:02:32 PDT 
Comment on attachment 232180 [details]
Patch

It seems the Mac WK2 EWS is flakey, this patch can't break any test, so cq? again.
Comment 5 Csaba Osztrogonác 2014-07-01 03:47:51 PDT 
Comment on attachment 232180 [details]
Patch

LGTM, r=me, but please don't set the execute permission for finder_unittest.py and main_unittest.py.
Comment 6 Éva Balázsfalvi 2014-07-01 04:07:14 PDT 
Created attachment 234155 [details]
patch for landing
Comment 7 Éva Balázsfalvi 2014-07-01 04:17:14 PDT 
Created attachment 234156 [details]
patch for landing
Comment 8 WebKit Commit Bot 2014-07-01 05:13:50 PDT 
Comment on attachment 234156 [details]
patch for landing

Rejecting attachment 234156 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 234156, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Csaba Osztrogonac found in /Volumes/Data/EWS/WebKit/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/4577065588228096
Comment 9 Éva Balázsfalvi 2014-07-01 05:20:10 PDT 
Created attachment 234159 [details]
patch for landing
Comment 10 WebKit Commit Bot 2014-07-01 06:09:43 PDT 
The commit-queue encountered the following flaky tests while processing attachment 234159 [details]:

media/video-ended-event-negative-playback.html bug 134490
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2014-07-01 06:10:45 PDT 
Comment on attachment 234159 [details]
patch for landing

Clearing flags on attachment: 234159

Committed r170637: <http://trac.webkit.org/changeset/170637>
Comment 12 WebKit Commit Bot 2014-07-01 06:10:52 PDT 
All reviewed patches have been landed.  Closing bug.