RESOLVED FIXED Bug 159343
WebRTC: update MediaStream-MediaElement-srcObject.html test and unskip it 
https://bugs.webkit.org/show_bug.cgi?id=159343
Summary WebRTC: update MediaStream-MediaElement-srcObject.html test and unskip it
Alejandro G. Castro
Reported 2016-07-01 05:08:09 PDT
There is an skipped test (MediaStream-MediaElement-srcObject.html) and we are not handling that situation correctly in the htmlmediaelement handler.
Attachments
Patch (5.08 KB, patch)
2016-11-10 05:10 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (5.81 KB, patch)
2016-11-11 01:56 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2016-11-10 05:01:09 PST
Checks were added to avoid the crash already but the test is not updated and it is skipped.
Alejandro G. Castro
Comment 2 2016-11-10 05:10:13 PST
Created attachment 294364 [details] Patch
Philippe Normand
Comment 3 2016-11-11 00:02:55 PST
Comment on attachment 294364 [details] Patch Maybe try to unskip it on Mac too?
Alejandro G. Castro
Comment 4 2016-11-11 01:52:03 PST
(In reply to comment #3) > Comment on attachment 294364 [details] > Patch > > Maybe try to unskip it on Mac too? Right, I'll include it.
Alejandro G. Castro
Comment 5 2016-11-11 01:56:20 PST
Created attachment 294487 [details] Patch
Alejandro G. Castro
Comment 6 2016-11-11 01:57:40 PST
I unskipped the test in the mac port but I could not test it, it would be great if youenn or eric can check the modification on mac before landing.
Philippe Normand
Comment 7 2016-11-11 04:44:48 PST
Comment on attachment 294487 [details] Patch The Mac EWS runs tests and didn't complain :)
WebKit Commit Bot
Comment 8 2016-11-15 04:14:03 PST
Comment on attachment 294487 [details] Patch Clearing flags on attachment: 294487 Committed r208729: <http://trac.webkit.org/changeset/208729>
WebKit Commit Bot
Comment 9 2016-11-15 04:14:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.