202725 failure #28700 Failed exiting early after 0 crashes and 50 timeouts. 7352 tests run. 60 failures 1 new passes 1 missing results api tests ... 202534 failure #28634 Failed exiting early after 0 crashes and 50 timeouts. 7349 tests run. 78 failures 1 new passes 4 missing results api tests 202531 failure #28633 Failed 196 failures 35 new passes 27 flakes 5 missing results EFL port's layout test failed for a long time.
Created attachment 282533 [details] Patch
Attachment 282533 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:82: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:65: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 282533 [details] Patch Patch looks good because this is copied from DrawingAreaProxyImpl::dispatchAfterEnsuringDrawing(). But please fix style error.
I think that is false positive. Other codes also add white space before '(' in function callback.
(In reply to comment #4) > I think that is false positive. > Other codes also add white space before '(' in function callback. No, there are definitely code which follows coding style. If there is no rational reason, I think we have to adhere coding style alarm. void StackVisitor::Frame::dump(PrintStream& out, Indenter indent, std::function<void(PrintStream&)> prefix) const { if (!this->callFrame()) { out.print(indent, "frame 0x0\n"); return; }
Created attachment 282548 [details] Patch
(In reply to comment #5) > (In reply to comment #4) > > I think that is false positive. > > Other codes also add white space before '(' in function callback. > > No, there are definitely code which follows coding style. If there is no > rational reason, I think we have to adhere coding style alarm. > > void StackVisitor::Frame::dump(PrintStream& out, Indenter indent, > std::function<void(PrintStream&)> prefix) const > { > if (!this->callFrame()) { > out.print(indent, "frame 0x0\n"); > return; > } Okay. I changed it!!
Comment on attachment 282548 [details] Patch r=me.
Comment on attachment 282548 [details] Patch Clearing flags on attachment: 282548 Committed r202773: <http://trac.webkit.org/changeset/202773>
All reviewed patches have been landed. Closing bug.