Bug 159077 - [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
Summary: [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render se...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Depends on:
Blocks: 159337
  Show dependency treegraph
Reported: 2016-06-23 16:38 PDT by Simon Fraser (smfr)
Modified: 2016-07-01 02:55 PDT (History)
5 users (show)

See Also:

Patch (22.66 KB, patch)
2016-06-23 16:41 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (9.59 KB, patch)
2016-06-27 17:44 PDT, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-06-23 16:38:52 PDT
[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
Comment 1 Simon Fraser (smfr) 2016-06-23 16:41:42 PDT
Created attachment 281941 [details]
Comment 2 Tim Horton 2016-06-23 16:44:36 PDT
Comment on attachment 281941 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=281941&action=review

> Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h:172
> +EXTERN_C uint8_t *CARenderServerGetBufferData(CARenderServerBufferRef);

star's on the wrong side :P

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:211
> +    int bufferWidth = ceil(bufferSize.width * deviceScaleFactor);

I could see someone making use of bufferSize and it being wrong here.

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:220
> +    CARenderServerRenderLayerWithTransform(MACH_PORT_NULL, [m_view layer].context.contextId, reinterpret_cast<uint64_t>(m_view.layer), buffer, 0, 0, &transform);

Comment 4 Simon Fraser (smfr) 2016-06-23 20:32:22 PDT
Have to disable this in WTR because we have some synchronization issues (the "wait for the web process" is broken).
Comment 5 Simon Fraser (smfr) 2016-06-27 17:44:35 PDT
Created attachment 282195 [details]
Comment 6 WebKit Commit Bot 2016-06-27 17:45:53 PDT
Attachment 282195 [details] did not pass style-queue:

ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2891:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 7 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Simon Fraser (smfr) 2016-06-27 18:46:06 PDT
Comment 8 Simon Fraser (smfr) 2016-06-27 18:46:17 PDT
I'll garden the iOS tests.
Comment 9 Simon Fraser (smfr) 2016-06-27 22:56:56 PDT
Followup fix in r202540.