Bug 159325 – Web Inspector: Fix inspector/debugger/pause-reason.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
This test currently fails.

Steps to Reproduce:
1. shell> run-webkit-tests --force inspector/debugger/pause-reason.html
  => Fail

Notes:
Seems to fail because we don't pause where we expect to pause due to test behavior.
Change the "pause on next statement" to not pause on inspector code, but instead pause on page code.

[Joseph Pecoraro]

*** Bug 151893 has been marked as a duplicate of this bug. ***

[Joseph Pecoraro]

Created attachment 282499 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 282499 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282499&action=review

> LayoutTests/inspector/debugger/pause-reason.html:33
>              test.setup();

If there are other evaluateOnPage things queued up, how do we guarantee that the pause will be on test.expression and not some other expression?

[Joseph Pecoraro]

(In reply to comment #3)
> Comment on attachment 282499 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282499&action=review
> 
> > LayoutTests/inspector/debugger/pause-reason.html:33
> >              test.setup();
> 
> If there are other evaluateOnPage things queued up, how do we guarantee that
> the pause will be on test.expression and not some other expression?

I'm not sure there is a way we can guarantee this.

This test is testing evaluateInPage + pause on next statement. If anything happens in between the test will be broken. That said, one possible solution might be evaluateInPage where the Runtime.evaluate options include doNotPauseOnExceptionsAndMuteConsole:true to evaluate a "setTimeout(something,0)". Not sure that is much better.

What do you think?

[WebKit Commit Bot]

Comment on attachment 282499 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 282499

Committed r202783: <http://trac.webkit.org/changeset/202783>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.