Bug 151893 – Re-enable inspector/debugger/pause-reason after fixing 151892

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Tools / Tests

[Michael Saboff]

After fixing bug #151892, we can re-enable the inspector/debugger/pause-reason test.

[Michael Saboff]

Created attachment 266680 [details]
Patch

[Mark Lam]

Comment on attachment 266680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266680&action=review

> LayoutTests/platform/mac/TestExpectations:1413
> -webkit.org/b/149774 css3/font-variant-font-face-override.html [ Pass Failure ImageOnlyFailure ]
>  \ No newline at end of file
> +webkit.org/b/149774 css3/font-variant-font-face-override.html [ Pass Failure ImageOnlyFailure ]

Is this relevant?

[Michael Saboff]

(In reply to comment #2)
> Comment on attachment 266680 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266680&action=review
> 
> > LayoutTests/platform/mac/TestExpectations:1413
> > -webkit.org/b/149774 css3/font-variant-font-face-override.html [ Pass Failure ImageOnlyFailure ]
> >  \ No newline at end of file
> > +webkit.org/b/149774 css3/font-variant-font-face-override.html [ Pass Failure ImageOnlyFailure ]
> 
> Is this relevant?

No.  Probably due to the last check-in.

[Mark Lam]

Comment on attachment 266680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266680&action=review

> LayoutTests/inspector/debugger/pause-reason.html:62
> +        WebInspector.debuggerManager.addEventListener(WebInspector.DebuggerManager.Event.Resumed, function(event) {
> +            InspectorTest.log("RESUMED");
> +            InspectorTest.log("");
> +
> +            nextTestCase();
> +        });
> +

Why did you moved this in here?  Would this not add a new Resume listener every time the debugger pauses?  That doesn't seem right.

[Mark Lam]

Comment on attachment 266680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266680&action=review

>> LayoutTests/inspector/debugger/pause-reason.html:62
>> +        WebInspector.debuggerManager.addEventListener(WebInspector.DebuggerManager.Event.Resumed, function(event) {
>> +            InspectorTest.log("RESUMED");
>> +            InspectorTest.log("");
>> +
>> +            nextTestCase();
>> +        });
>> +
> 
> Why did you moved this in here?  Would this not add a new Resume listener every time the debugger pauses?  That doesn't seem right.

Argh ... I meant the whole blob of "WebInspector.debuggerManager.addEventListener(WebInspector.DebuggerManager.Event.Resumed ..."

[Joseph Pecoraro]

Comment on attachment 266680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266680&action=review

r=me, we know we have to clean up these debugger tests due to how DebuggerMangaer.Event.Pause/Resume fire. It is good that we have test coverage for this though.

>>> LayoutTests/inspector/debugger/pause-reason.html:62
>>> +
>> 
>> Why did you moved this in here?  Would this not add a new Resume listener every time the debugger pauses?  That doesn't seem right.
> 
> Argh ... I meant the whole blob of "WebInspector.debuggerManager.addEventListener(WebInspector.DebuggerManager.Event.Resumed ..."

This was moved up here because (1) reloadPage may trigger DebuggerManager.Event.Resumed and (2) we only want to listen for Resume and fire "nextTestCase" once the "pause-reasons.js" script has been added.

Because we listen for pause-reasons.js to get added, this should happen only once during this test.

>>> LayoutTests/platform/mac/TestExpectations:1413
>>> +webkit.org/b/149774 css3/font-variant-font-face-override.html [ Pass Failure ImageOnlyFailure ]
>> 
>> Is this relevant?
> 
> No.  Probably due to the last check-in.

This is just adding the missing newline at the end of the file. Keep it!

[Build Bot]

Comment on attachment 266680 [details]
Patch

Attachment 266680 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/517383

New failing tests:
inspector/debugger/pause-reason.html

[Build Bot]

Created attachment 266688 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Michael Saboff]

(In reply to comment #8)
> Created attachment 266688 [details]
> Archive of layout-test-results from ews106 for mac-yosemite-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> mac-wk2-ews.
> Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

Mac test crashed due to the fix for https://bugs.webkit.org/show_bug.cgi?id=151892 having not yet landed.

[Joseph Pecoraro]

I will be fixing this test as part of bug 159325.

*** This bug has been marked as a duplicate of bug 159325 ***