Bug 159254 - WebRTC: Implement MediaEndpointPeerConnection::setConfiguration()
Summary: WebRTC: Implement MediaEndpointPeerConnection::setConfiguration()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 143211
  Show dependency treegraph
 
Reported: 2016-06-29 01:17 PDT by Adam Bergkvist
Modified: 2016-06-29 21:49 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch (27.86 KB, patch)
2016-06-29 01:45 PDT, Adam Bergkvist
eric.carlson: review+
Details | Formatted Diff | Diff
Updated patch (for landing) (27.77 KB, patch)
2016-06-29 10:29 PDT, Adam Bergkvist
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (1005.87 KB, application/zip)
2016-06-29 11:09 PDT, Build Bot
no flags Details
Patch for landing (27.77 KB, patch)
2016-06-29 13:15 PDT, Adam Bergkvist
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Bergkvist 2016-06-29 01:17:21 PDT
MediaEndpointPeerConnection::setConfiguration() is the MediaEndpointPeerConnection implementation of RTCPeerConnection.steConfiguration() [1].

[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcpeerconnection-setconfiguration
Comment 1 Adam Bergkvist 2016-06-29 01:45:50 PDT
Created attachment 282332 [details]
Proposed patch
Comment 2 Eric Carlson 2016-06-29 08:23:18 PDT
Comment on attachment 282332 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282332&action=review

> Source/WebCore/platform/mediastream/PeerConnectionStates.h:32
> +#ifndef PeerConnectionStates_h
> +#define PeerConnectionStates_h

Nit: this can use "#pragma once"
Comment 3 Adam Bergkvist 2016-06-29 10:29:15 PDT
Created attachment 282356 [details]
Updated patch (for landing)
Comment 4 Adam Bergkvist 2016-06-29 10:29:40 PDT
(In reply to comment #2)

Thanks for reviewing

> Comment on attachment 282332 [details]
> Proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282332&action=review
> 
> > Source/WebCore/platform/mediastream/PeerConnectionStates.h:32
> > +#ifndef PeerConnectionStates_h
> > +#define PeerConnectionStates_h
> 
> Nit: this can use "#pragma once"

Fixed
Comment 5 Build Bot 2016-06-29 11:09:18 PDT
Comment on attachment 282356 [details]
Updated patch (for landing)

Attachment 282356 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1595383

New failing tests:
animations/multiple-backgrounds.html
Comment 6 Build Bot 2016-06-29 11:09:20 PDT
Created attachment 282361 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 7 Adam Bergkvist 2016-06-29 13:15:20 PDT
Created attachment 282367 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2016-06-29 21:49:50 PDT
Comment on attachment 282367 [details]
Patch for landing

Clearing flags on attachment: 282367

Committed r202671: <http://trac.webkit.org/changeset/202671>
Comment 9 WebKit Commit Bot 2016-06-29 21:49:53 PDT
All reviewed patches have been landed.  Closing bug.