Bug 159104 - REGRESSION: Weak symbol warning when linking TestWebKitAPI
Summary: REGRESSION: Weak symbol warning when linking TestWebKitAPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 158625
Blocks:
  Show dependency tree / graph
 
Reported: 2016-06-24 15:44 PDT by Filip Pizlo
Modified: 2016-06-25 12:08 PDT (History)
3 users (show)

See Also:

Attachments
the patch (1.59 KB, patch)
2016-06-24 15:45 PDT, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
the patch (2.68 KB, patch)
2016-06-25 12:03 PDT, Filip Pizlo 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-06-24 15:44:55 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-06-24 15:45:51 PDT 
Created attachment 282021 [details]
the patch
Comment 2 Mark Lam 2016-06-24 16:47:31 PDT 
Comment on attachment 282021 [details]
the patch

rs=me
Comment 3 Filip Pizlo 2016-06-24 16:49:55 PDT 
Landed in https://trac.webkit.org/changeset/202461
Comment 4 mitz 2016-06-24 16:57:32 PDT 
Comment on attachment 282021 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282021&action=review

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2339
> +				OTHER_CPLUSPLUSFLAGS = (
> +					"$(inherited)",
> +					"-ftemplate-depth=256",
> +					"-fvisibility=hidden",
> +				);

Build settings should go into TestWTFLibrary.xcconfig, not into the project file…

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2351
> +				OTHER_CPLUSPLUSFLAGS = (
> +					"$(inherited)",
> +					"-ftemplate-depth=256",
> +					"-fvisibility=hidden",
> +				);

…so they don’t have to be repeated like this.
Comment 5 Filip Pizlo 2016-06-24 16:58:23 PDT 
(In reply to comment #4)
> Comment on attachment 282021 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282021&action=review
> 
> > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2339
> > +				OTHER_CPLUSPLUSFLAGS = (
> > +					"$(inherited)",
> > +					"-ftemplate-depth=256",
> > +					"-fvisibility=hidden",
> > +				);
> 
> Build settings should go into TestWTFLibrary.xcconfig, not into the project
> file…
> 
> > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2351
> > +				OTHER_CPLUSPLUSFLAGS = (
> > +					"$(inherited)",
> > +					"-ftemplate-depth=256",
> > +					"-fvisibility=hidden",
> > +				);
> 
> …so they don’t have to be repeated like this.

You're right.  I should have remembered this.
Comment 6 Filip Pizlo 2016-06-24 17:01:43 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > Comment on attachment 282021 [details]
> > the patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=282021&action=review
> > 
> > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2339
> > > +				OTHER_CPLUSPLUSFLAGS = (
> > > +					"$(inherited)",
> > > +					"-ftemplate-depth=256",
> > > +					"-fvisibility=hidden",
> > > +				);
> > 
> > Build settings should go into TestWTFLibrary.xcconfig, not into the project
> > file…
> > 
> > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2351
> > > +				OTHER_CPLUSPLUSFLAGS = (
> > > +					"$(inherited)",
> > > +					"-ftemplate-depth=256",
> > > +					"-fvisibility=hidden",
> > > +				);
> > 
> > …so they don’t have to be repeated like this.
> 
> You're right.  I should have remembered this.

Actually, it appears that everywhere else, we set this option in the project.pbxproj.  But we do it differently.  I'll upload a patch.
Comment 7 Filip Pizlo 2016-06-25 11:51:30 PDT 
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Comment on attachment 282021 [details]
> > > the patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=282021&action=review
> > > 
> > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2339
> > > > +				OTHER_CPLUSPLUSFLAGS = (
> > > > +					"$(inherited)",
> > > > +					"-ftemplate-depth=256",
> > > > +					"-fvisibility=hidden",
> > > > +				);
> > > 
> > > Build settings should go into TestWTFLibrary.xcconfig, not into the project
> > > file…
> > > 
> > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2351
> > > > +				OTHER_CPLUSPLUSFLAGS = (
> > > > +					"$(inherited)",
> > > > +					"-ftemplate-depth=256",
> > > > +					"-fvisibility=hidden",
> > > > +				);
> > > 
> > > …so they don’t have to be repeated like this.
> > 
> > You're right.  I should have remembered this.
> 
> Actually, it appears that everywhere else, we set this option in the
> project.pbxproj.  But we do it differently.  I'll upload a patch.

Wrong again!  The xcconfig option is:

GCC_SYMBOLS_PRIVATE_EXTERN = YES;
Comment 8 Filip Pizlo 2016-06-25 12:03:57 PDT 
Created attachment 282081 [details]
the patch
Comment 9 Filip Pizlo 2016-06-25 12:08:09 PDT 
Landed in https://trac.webkit.org/changeset/202469