Bug 158625 - Refactor TestWebKitAPI to allow just testing WTF
Summary: Refactor TestWebKitAPI to allow just testing WTF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks: 159104
  Show dependency treegraph
 
Reported: 2016-06-10 11:18 PDT by Sam Weinig
Modified: 2016-06-25 06:07 PDT (History)
3 users (show)

See Also:


Attachments
Patch (107.32 KB, patch)
2016-06-10 11:25 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (106.26 KB, patch)
2016-06-10 11:30 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (105.53 KB, patch)
2016-06-10 12:06 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (106.02 KB, patch)
2016-06-10 12:45 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2016-06-10 11:18:17 PDT
Refactor TestWebKitAPI to allow just testing WTF
Comment 1 Sam Weinig 2016-06-10 11:25:45 PDT
Created attachment 281017 [details]
Patch
Comment 2 Sam Weinig 2016-06-10 11:30:45 PDT
Created attachment 281018 [details]
Patch
Comment 3 Tim Horton 2016-06-10 11:31:11 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=281017&action=review

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:457
> +			dstPath = /usr/share/man/man1/;

??

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:1791
> +			productInstallPath = "$(HOME)/bin";

???
Comment 4 Simon Fraser (smfr) 2016-06-10 11:32:46 PDT
Might as well sort all the project files too.

> Tools/TestWebKitAPI/cocoa/UtilitiesCocoa.mm:40
> +    usleep(seconds * 1000000);

Can you make this USEC_PER_SEC
Comment 5 Sam Weinig 2016-06-10 12:06:55 PDT
Created attachment 281026 [details]
Patch
Comment 6 Sam Weinig 2016-06-10 12:45:15 PDT
Created attachment 281034 [details]
Patch
Comment 7 Sam Weinig 2016-06-10 13:37:02 PDT
Committed r201938: <http://trac.webkit.org/changeset/201938>