WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
159019
Fix style issues in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=159019
Summary
Fix style issues in webkitpy
Aakash Jain
Reported
2016-06-21 23:42:20 PDT
Running "./Tools/Scripts/check-webkit-style Tools/Script/webkitpy" reports a lot of issues. Although not a high priority, but we should fix these issues as much as possible. It would help maintain the formatting style and quality. Sometimes these issues are encountered while we are making changes in similar portion of code and run check-webkit-style. At that time, it might be confusing whether the formatting issues were pre-existing or introduced by us.
Attachments
Proposed patch
(103.08 KB, patch)
2016-06-21 23:48 PDT
,
Aakash Jain
dbates
: review+
dbates
: commit-queue-
Details
Formatted Diff
Diff
Updated patch
(92.74 KB, patch)
2016-06-22 17:44 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2016-06-21 23:48:35 PDT
Created
attachment 281823
[details]
Proposed patch
Daniel Bates
Comment 2
2016-06-22 09:07:23 PDT
Comment on
attachment 281823
[details]
Proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=281823&action=review
OK. I'm unclear how many people are actively working in webkitpy at the moment. This change could be seen as disruptive to people that have patches in development or in flight given the number of files this patch touches. You may want to consider giving a heads up about this change on webkit-dev.
> Tools/ChangeLog:51 > + * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: > + (BrowserDriver): > + * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: > + (BrowserDriverFactory): > + (BrowserDriverFactory.available_platforms): > + * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: > + (ServerControl): > + * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: > + (SimpleHTTPServerDriver.serve): > + * Scripts/webkitpy/benchmark_runner/utils.py: > + (force_remove): > + (TimeoutError): > + * Scripts/webkitpy/common/checkout/changelog.py: > + (ChangeLogEntry.is_touched_files_text_clean): > + (ChangeLog): > + * Scripts/webkitpy/common/checkout/changelog_unittest.py: > + (test_prepend_text): > + * Scripts/webkitpy/common/checkout/checkout.py: > + (Checkout.bug_id_for_this_commit): > + (Checkout): > + (Checkout.apply_patch): > + * Scripts/webkitpy/common/checkout/checkout_mock.py: > + (MockCheckout): > + (MockCheckout.__init__): > + * Scripts/webkitpy/common/checkout/checkout_unittest.py: > + (CheckoutTest): > + (CheckoutTest._make_checkout): > + * Scripts/webkitpy/common/checkout/commitinfo.py: > + (CommitInfo.responsible_parties): > + (CommitInfo): > + (CommitInfo.blame_string): > + * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: > + (CommitInfoTest): > + (CommitInfoTest.test_commit_info_creation): > + * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: > + (DiffParserTest): > + (DiffParserTest.test_diff_parser): > + (DiffParserTest.test_git_mnemonicprefix): > + * Scripts/webkitpy/common/checkout/scm/scm.py: > + (AuthenticationError.__init__): > + (SCM):
We tend to elide changed functions or truncate the list of changed files for brevity when making large scale mechanical changes. I suggest that that we elide the changed functions. One example of a changeset that elides the list of changed functions is <
http://trac.webkit.org/changeset/97854
>.
Aakash Jain
Comment 3
2016-06-22 17:44:17 PDT
Created
attachment 281889
[details]
Updated patch elided changed functions in ChangeLog.
WebKit Commit Bot
Comment 4
2016-06-22 18:13:58 PDT
Comment on
attachment 281889
[details]
Updated patch Clearing flags on attachment: 281889 Committed
r202362
: <
http://trac.webkit.org/changeset/202362
>
WebKit Commit Bot
Comment 5
2016-06-22 18:14:03 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug