Bug 159008 - Fix style issues in webkitpy/tool
Summary: Fix style issues in webkitpy/tool
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Depends on:
Reported: 2016-06-21 19:17 PDT by Aakash Jain
Modified: 2016-06-22 00:01 PDT (History)
6 users (show)

See Also:

Proposed patch (66.74 KB, patch)
2016-06-21 19:26 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Proposed patch (66.18 KB, patch)
2016-06-21 19:27 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Updated patch (66.00 KB, patch)
2016-06-21 19:37 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Another patch (71.86 KB, patch)
2016-06-21 22:42 PDT, Aakash Jain
dbates: review-
dbates: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2016-06-21 19:17:51 PDT
Running "./Tools/Scripts/check-webkit-style Tools/Script/webkitpy" reports a lot of issues. Although not a high priority, but we should fix these issues as much as possible. It would help maintain the formatting style and quality. 

Sometimes these issues are encountered while we are making changes in similar portion of code and run check-webkit-style. At that time, it might be confusing whether the formatting issues were pre-existing or introduced by us.
Comment 1 Aakash Jain 2016-06-21 19:26:09 PDT
Created attachment 281804 [details]
Proposed patch

This patch fixes the formatting issues in webkitpy/tool directory.

examples of error reported by check-webkit-style:
ERROR: Tools/Scripts/webkitpy/tool/steps/metastep.py:35:  expected 1 blank line, found 0  [pep8/E301] [5]
ERROR: Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:35:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py:175:  too many blank lines (2)  [pep8/E303] [5]
ERROR: Tools/Scripts/webkitpy/tool/steps/metastep.py:54:  indentation is not a multiple of four  [pep8/E111] [5]
ERROR: Tools/Scripts/webkitpy/tool/steps/update.py:16:  trailing whitespace  [pep8/W291] [5]
Comment 2 Aakash Jain 2016-06-21 19:27:56 PDT
Created attachment 281805 [details]
Proposed patch
Comment 3 WebKit Commit Bot 2016-06-21 19:30:42 PDT
Attachment 281805 [details] did not pass style-queue:

ERROR: Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py:131:  no spaces around keyword / parameter equals  [pep8/E251] [5]
ERROR: Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py:132:  no spaces around keyword / parameter equals  [pep8/E251] [5]
Total errors found: 2 in 54 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Aakash Jain 2016-06-21 19:37:44 PDT
Created attachment 281806 [details]
Updated patch
Comment 5 WebKit Commit Bot 2016-06-21 20:34:16 PDT
Comment on attachment 281806 [details]
Updated patch

Clearing flags on attachment: 281806

Committed r202319: <http://trac.webkit.org/changeset/202319>
Comment 6 WebKit Commit Bot 2016-06-21 20:34:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Aakash Jain 2016-06-21 22:42:50 PDT
Created attachment 281817 [details]
Another patch

This patch fixes the formatting issues in webkitpy directory.
Comment 8 Daniel Bates 2016-06-21 22:56:35 PDT
Comment on attachment 281817 [details]
Another patch

Please file a new bug with this patch. In general we prefer one patch per bug because it keeps the bug focused and serves as a venue for discussion about the patch.