Bug 159008 – Fix style issues in webkitpy/tool

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Running "./Tools/Scripts/check-webkit-style Tools/Script/webkitpy" reports a lot of issues. Although not a high priority, but we should fix these issues as much as possible. It would help maintain the formatting style and quality. 

Sometimes these issues are encountered while we are making changes in similar portion of code and run check-webkit-style. At that time, it might be confusing whether the formatting issues were pre-existing or introduced by us.

[Aakash Jain]

Created attachment 281804 [details]
Proposed patch

This patch fixes the formatting issues in webkitpy/tool directory.

examples of error reported by check-webkit-style:
ERROR: Tools/Scripts/webkitpy/tool/steps/metastep.py:35:  expected 1 blank line, found 0  [pep8/E301] [5]
ERROR: Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:35:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py:175:  too many blank lines (2)  [pep8/E303] [5]
ERROR: Tools/Scripts/webkitpy/tool/steps/metastep.py:54:  indentation is not a multiple of four  [pep8/E111] [5]
ERROR: Tools/Scripts/webkitpy/tool/steps/update.py:16:  trailing whitespace  [pep8/W291] [5]

[Aakash Jain]

Created attachment 281805 [details]
Proposed patch

[WebKit Commit Bot]

Attachment 281805 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py:131:  no spaces around keyword / parameter equals  [pep8/E251] [5]
ERROR: Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py:132:  no spaces around keyword / parameter equals  [pep8/E251] [5]
Total errors found: 2 in 54 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Aakash Jain]

Created attachment 281806 [details]
Updated patch

[WebKit Commit Bot]

Comment on attachment 281806 [details]
Updated patch

Clearing flags on attachment: 281806

Committed r202319: <http://trac.webkit.org/changeset/202319>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Aakash Jain]

Created attachment 281817 [details]
Another patch

This patch fixes the formatting issues in webkitpy directory.

[Daniel Bates]

Comment on attachment 281817 [details]
Another patch

Please file a new bug with this patch. In general we prefer one patch per bug because it keeps the bug focused and serves as a venue for discussion about the patch.