Bug 158834 - The JSBuiltinConstructor feature can't handle a JS interface extending an other JS interface
Summary: The JSBuiltinConstructor feature can't handle a JS interface extending an oth...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks: 143211 158832
  Show dependency treegraph
 
Reported: 2016-06-16 05:47 PDT by Adam Bergkvist
Modified: 2016-06-19 10:52 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.29 KB, patch)
2016-06-16 06:06 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Bergkvist 2016-06-16 05:47:05 PDT
For example:

interface RTCPeerConnection : EventTarget
Comment 1 youenn fablet 2016-06-16 06:06:54 PDT
Created attachment 281451 [details]
Patch
Comment 2 youenn fablet 2016-06-16 06:07:55 PDT
(In reply to comment #1)
> Created attachment 281451 [details]
> Patch

Adam, can you check whether that patch is working for you?
Comment 3 Adam Bergkvist 2016-06-16 08:48:28 PDT
The test fast/mediastream/RTCRtpSender-replaceTrack.html seem to crash with this change applied. Haven't looked into the cause yet.
Comment 4 Adam Bergkvist 2016-06-17 00:18:35 PDT
(In reply to comment #3)
> The test fast/mediastream/RTCRtpSender-replaceTrack.html seem to crash with
> this change applied. Haven't looked into the cause yet.

Don't mind the above comment. The patch works for me.
Comment 5 Adam Bergkvist 2016-06-18 06:40:42 PDT
youenn, are you planning to update this patch any further or can we commit it? Many thanks for the fix btw :)
Comment 6 youenn fablet 2016-06-18 08:18:06 PDT
Sure, I cannot follow the CQ right now, but will do tomorrow or Monday.
Feel free to CQ+ it in the meantime if you prefer
Comment 7 WebKit Commit Bot 2016-06-19 10:51:59 PDT
Comment on attachment 281451 [details]
Patch

Clearing flags on attachment: 281451

Committed r202211: <http://trac.webkit.org/changeset/202211>
Comment 8 WebKit Commit Bot 2016-06-19 10:52:04 PDT
All reviewed patches have been landed.  Closing bug.