Bug 158831 - WebRTC: Robustify 'this' type check in RTCPeerConnection JS built-ins
Summary: WebRTC: Robustify 'this' type check in RTCPeerConnection JS built-ins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 158832
Blocks: 143211
  Show dependency tree / graph
 
Reported: 2016-06-16 01:20 PDT by Adam Bergkvist
Modified: 2016-06-28 08:11 PDT (History)
2 users (show)

See Also:

Attachments
Patch for review (6.18 KB, patch)
2016-06-27 01:19 PDT, Adam Bergkvist 		no flags Details | Formatted Diff | Diff
Updated patch (9.30 KB, patch)
2016-06-28 02:12 PDT, Adam Bergkvist 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Bergkvist 2016-06-16 01:20:53 PDT 
The current check relies on the prototype which isn't robust enough.
Comment 1 Adam Bergkvist 2016-06-27 01:19:11 PDT 
Created attachment 282110 [details]
Patch for review
Comment 2 Adam Bergkvist 2016-06-27 01:25:58 PDT 
Youenn, is the third set of tests actually valid to test this feature?
Comment 3 youenn fablet 2016-06-27 23:35:54 PDT 
Comment on attachment 282110 [details]
Patch for review

r=me
Comment 4 youenn fablet 2016-06-27 23:43:00 PDT 
(In reply to comment #2)
> Youenn, is the third set of tests actually valid to test this feature?

The test should probably be updated to use Object.setPrototypeOf.
Comment 5 youenn fablet 2016-06-27 23:46:08 PDT 
(In reply to comment #3)
> Comment on attachment 282110 [details]
> Patch for review
> 
> r=me

I think this patch is good to go. I r+ed it.
At the same time, it might be better to check again the third set of tests and maybe update the test. Hence why I removed the r+, especially since there was no r? at the beginning
Comment 6 Adam Bergkvist 2016-06-28 02:12:04 PDT 
Created attachment 282226 [details]
Updated patch
Comment 7 Adam Bergkvist 2016-06-28 07:50:27 PDT 
Comment on attachment 282226 [details]
Updated patch

Thanks Youenn
Comment 8 WebKit Commit Bot 2016-06-28 08:11:10 PDT 
Comment on attachment 282226 [details]
Updated patch

Clearing flags on attachment: 282226

Committed r202565: <http://trac.webkit.org/changeset/202565>
Comment 9 WebKit Commit Bot 2016-06-28 08:11:14 PDT 
All reviewed patches have been landed.  Closing bug.