RESOLVED FIXED Bug 158831
WebRTC: Robustify 'this' type check in RTCPeerConnection JS built-ins 
https://bugs.webkit.org/show_bug.cgi?id=158831
Summary WebRTC: Robustify 'this' type check in RTCPeerConnection JS built-ins
Adam Bergkvist
Reported 2016-06-16 01:20:53 PDT
The current check relies on the prototype which isn't robust enough.
Attachments
Patch for review (6.18 KB, patch)
2016-06-27 01:19 PDT, Adam Bergkvist 		no flags
DetailsFormatted DiffDiff
Updated patch (9.30 KB, patch)
2016-06-28 02:12 PDT, Adam Bergkvist 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Bergkvist
Comment 1 2016-06-27 01:19:11 PDT
Created attachment 282110 [details] Patch for review
Adam Bergkvist
Comment 2 2016-06-27 01:25:58 PDT
Youenn, is the third set of tests actually valid to test this feature?
youenn fablet
Comment 3 2016-06-27 23:35:54 PDT
Comment on attachment 282110 [details] Patch for review r=me
youenn fablet
Comment 4 2016-06-27 23:43:00 PDT
(In reply to comment #2) > Youenn, is the third set of tests actually valid to test this feature? The test should probably be updated to use Object.setPrototypeOf.
youenn fablet
Comment 5 2016-06-27 23:46:08 PDT
(In reply to comment #3) > Comment on attachment 282110 [details] > Patch for review > > r=me I think this patch is good to go. I r+ed it. At the same time, it might be better to check again the third set of tests and maybe update the test. Hence why I removed the r+, especially since there was no r? at the beginning
Adam Bergkvist
Comment 6 2016-06-28 02:12:04 PDT
Created attachment 282226 [details] Updated patch
Adam Bergkvist
Comment 7 2016-06-28 07:50:27 PDT
Comment on attachment 282226 [details] Updated patch Thanks Youenn
WebKit Commit Bot
Comment 8 2016-06-28 08:11:10 PDT
Comment on attachment 282226 [details] Updated patch Clearing flags on attachment: 282226 Committed r202565: <http://trac.webkit.org/changeset/202565>
WebKit Commit Bot
Comment 9 2016-06-28 08:11:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.