Bug 158738 - Enabling Shadow DOM for all platforms
Summary: Enabling Shadow DOM for all platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-14 08:06 PDT by Romain Bellessort
Modified: 2016-06-15 08:20 PDT (History)
2 users (show)

See Also:

Attachments
Patch (110.33 KB, patch)
2016-06-14 10:00 PDT, Romain Bellessort 		no flags Details | Formatted Diff | Diff
Patch (110.39 KB, patch)
2016-06-15 06:24 PDT, Romain Bellessort 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Bellessort 2016-06-14 08:06:26 PDT 
Following https://bugs.webkit.org/show_bug.cgi?id=158686, it seems that Shadow DOM can be enabled on all platforms and that corresponding build flag can be removed (a runtime flag is available).
Comment 1 Romain Bellessort 2016-06-14 10:00:50 PDT 
Created attachment 281264 [details]
Patch
Comment 2 WebKit Commit Bot 2016-06-15 01:11:57 PDT 
Comment on attachment 281264 [details]
Patch

Rejecting attachment 281264 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 281264, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
tching file Source/cmake/tools/vsprops/FeatureDefines.props
patching file Source/cmake/tools/vsprops/FeatureDefinesCairo.props
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/webkitperl/FeatureList.pm
patching file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
patching file ChangeLog

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/1505932
Comment 3 Romain Bellessort 2016-06-15 06:24:04 PDT 
Created attachment 281352 [details]
Patch
Comment 4 Romain Bellessort 2016-06-15 06:29:05 PDT 
Comment on attachment 281352 [details]
Patch

Same patch after a rebase
Comment 5 WebKit Commit Bot 2016-06-15 08:20:42 PDT 
Comment on attachment 281352 [details]
Patch

Clearing flags on attachment: 281352

Committed r202091: <http://trac.webkit.org/changeset/202091>
Comment 6 WebKit Commit Bot 2016-06-15 08:20:46 PDT 
All reviewed patches have been landed.  Closing bug.