Bug 158686 – [GTK] Enabling Shadow DOM by default

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Romain Bellessort]

Following https://bugs.webkit.org/show_bug.cgi?id=153772, enabling Shadow DOM by default in GTK+ seems possible.

[Romain Bellessort]

Created attachment 281168 [details]
Patch

[Carlos Garcia Campos]

LGTM, you should also update Source/cmake/OptionsGTK.cmake to enable it in production builds (or do you want to enable it only for development builds for now?). Why didn't you ask for review? is this supposed to be a WIP patch?

[Romain Bellessort]

(In reply to comment #2)
> LGTM, you should also update Source/cmake/OptionsGTK.cmake to enable it in
> production builds (or do you want to enable it only for development builds
> for now?). 

Thanks, I will upload another patch that addresses OptionsGTK.cmake (I was not sure about the impact so I went for the smallest change first).

> Why didn't you ask for review? is this supposed to be a WIP patch?

As this is my first patch I wanted to check that everything was ok prior to asking for review, but I will directly ask for review with the updated patch. Thanks again.

[Romain Bellessort]

Created attachment 281171 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 281171 [details]
Patch

Thanks!

[WebKit Commit Bot]

Comment on attachment 281171 [details]
Patch

Clearing flags on attachment: 281171

Committed r201989: <http://trac.webkit.org/changeset/201989>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

Ryosuke, do you agree?

I don't think it makes sense to enable it in OptionsGTK.cmake; we should probably match what other ports are doing, since there is no platform-specific implementation here, correct? If it's ready for all ports, it should be changed in WebKitFeatures.cmake, not OptionsGTK.cmake.

[Ryosuke Niwa]

Yeah, we should enable it on all platforms.  In fact, we should probably just get rid of the build flag altogether now since we have a runtime flag.