Bug 158686 - [GTK] Enabling Shadow DOM by default
Summary: [GTK] Enabling Shadow DOM by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 148695
  Show dependency treegraph
 
Reported: 2016-06-13 02:29 PDT by Romain Bellessort
Modified: 2016-06-15 16:52 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.45 KB, patch)
2016-06-13 05:33 PDT, Romain Bellessort
no flags Details | Formatted Diff | Diff
Patch (4.85 KB, patch)
2016-06-13 06:29 PDT, Romain Bellessort
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Bellessort 2016-06-13 02:29:02 PDT
Following https://bugs.webkit.org/show_bug.cgi?id=153772, enabling Shadow DOM by default in GTK+ seems possible.
Comment 1 Romain Bellessort 2016-06-13 05:33:12 PDT
Created attachment 281168 [details]
Patch
Comment 2 Carlos Garcia Campos 2016-06-13 05:41:44 PDT
LGTM, you should also update Source/cmake/OptionsGTK.cmake to enable it in production builds (or do you want to enable it only for development builds for now?). Why didn't you ask for review? is this supposed to be a WIP patch?
Comment 3 Romain Bellessort 2016-06-13 06:27:56 PDT
(In reply to comment #2)
> LGTM, you should also update Source/cmake/OptionsGTK.cmake to enable it in
> production builds (or do you want to enable it only for development builds
> for now?). 

Thanks, I will upload another patch that addresses OptionsGTK.cmake (I was not sure about the impact so I went for the smallest change first).

> Why didn't you ask for review? is this supposed to be a WIP patch?

As this is my first patch I wanted to check that everything was ok prior to asking for review, but I will directly ask for review with the updated patch. Thanks again.
Comment 4 Romain Bellessort 2016-06-13 06:29:11 PDT
Created attachment 281171 [details]
Patch
Comment 5 Carlos Garcia Campos 2016-06-13 06:46:13 PDT
Comment on attachment 281171 [details]
Patch

Thanks!
Comment 6 WebKit Commit Bot 2016-06-13 07:08:43 PDT
Comment on attachment 281171 [details]
Patch

Clearing flags on attachment: 281171

Committed r201989: <http://trac.webkit.org/changeset/201989>
Comment 7 WebKit Commit Bot 2016-06-13 07:08:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Michael Catanzaro 2016-06-13 08:46:18 PDT
Ryosuke, do you agree?

I don't think it makes sense to enable it in OptionsGTK.cmake; we should probably match what other ports are doing, since there is no platform-specific implementation here, correct? If it's ready for all ports, it should be changed in WebKitFeatures.cmake, not OptionsGTK.cmake.
Comment 9 Ryosuke Niwa 2016-06-13 12:24:13 PDT
Yeah, we should enable it on all platforms.  In fact, we should probably just get rid of the build flag altogether now since we have a runtime flag.