Bug 153772 – [GTK] [EFL] [AppleWin] Layout Test fast/shadow-dom/slot-removal-crash-2.html timeouts

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Alberto Lopez Perez]

The following layout test is timing out on platforms GTK+, EFL and AppleWin since it was added on r195727 <http://trac.webkit.org/r195727>

Regressions: Unexpected timeouts (1)
  fast/shadow-dom/slot-removal-crash-2.html [ Timeout ]

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=fast%2Fshadow-dom%2Fslot-removal-crash-2.html

Probable cause: unknown.

[Ryosuke Niwa]

Created attachment 270442 [details]
Fixes the test

[Carlos Alberto Lopez Perez]

I have updated the GTK+, EFL and AppleWin expectations regarding this test on http://trac.webkit.org/changeset/195986

[Carlos Alberto Lopez Perez]

(In reply to comment #1)
> Created attachment 270442 [details]
> Fixes the test

I have just tested this patch on the GTK+ port.

The test not longer timeouts, but now it fails with the following text:

-- /home/clopez/webkit/webkit/layout-test-results/fast/shadow-dom/slot-removal-crash-2-expected.txt
+++ /home/clopez/webkit/webkit/layout-test-results/fast/shadow-dom/slot-removal-crash-2-actual.txt
@@ -1,5 +1,5 @@
+CONSOLE MESSAGE: line 23: TypeError: host.attachShadow is not a function. (In 'host.attachShadow({mode: 'open'})', 'host.attachShadow' is undefined)
 Test that removing a slot element with text node does not result in an assertion failure.
 The test passes if WebKit does not hit an assertion.
-PASS.

[Build Bot]

Comment on attachment 270442 [details]
Fixes the test

Attachment 270442 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/770055

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-1.html

[Build Bot]

Created attachment 270458 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Ryosuke Niwa]

(In reply to comment #3)
> (In reply to comment #1)
> > Created attachment 270442 [details]
> > Fixes the test
> 
> I have just tested this patch on the GTK+ port.
> 
> The test not longer timeouts, but now it fails with the following text:
> 
> --
> /home/clopez/webkit/webkit/layout-test-results/fast/shadow-dom/slot-removal-
> crash-2-expected.txt
> +++
> /home/clopez/webkit/webkit/layout-test-results/fast/shadow-dom/slot-removal-
> crash-2-actual.txt
> @@ -1,5 +1,5 @@
> +CONSOLE MESSAGE: line 23: TypeError: host.attachShadow is not a function.
> (In 'host.attachShadow({mode: 'open'})', 'host.attachShadow' is undefined)
>  Test that removing a slot element with text node does not result in an
> assertion failure.
>  The test passes if WebKit does not hit an assertion.
> -PASS.

That's expected because shadow DOM API isn't enabled on GTK+ port.

[Michael Catanzaro]

It's OFF by default in WebKitFeatures.cmake, and in FeatureList.pm it's enabled only for Mac and iOS.

I suspect this is a mistake; is there a reason it should not be enabled by default? Why is it a build option at all?

[Ryosuke Niwa]

(In reply to comment #7)
> It's OFF by default in WebKitFeatures.cmake, and in FeatureList.pm it's
> enabled only for Mac and iOS.
> 
> I suspect this is a mistake; is there a reason it should not be enabled by
> default? Why is it a build option at all?

The feature wasn't / isn't ready for production use.  You can follow the progress on https://bugs.webkit.org/show_bug.cgi?id=148695.

[Ryosuke Niwa]

Committed r196000: <http://trac.webkit.org/changeset/196000>

[Romain Bellessort]

I found an XMLHttpRequest test that fails with GTK due to the missing support of shadow DOM. When enabled, the test passes, and so do all fast/shadow-dom tests that pass on Mac. Would it make sense to enable shadow DOM for GTK by default or is it still too early?

[Carlos Garcia Campos]

(In reply to comment #10)
> I found an XMLHttpRequest test that fails with GTK due to the missing
> support of shadow DOM. When enabled, the test passes, and so do all
> fast/shadow-dom tests that pass on Mac. Would it make sense to enable shadow
> DOM for GTK by default or is it still too early?

I think we can enable it in GTK+ now.

[Romain Bellessort]

(In reply to comment #11)
> (In reply to comment #10)
> > I found an XMLHttpRequest test that fails with GTK due to the missing
> > support of shadow DOM. When enabled, the test passes, and so do all
> > fast/shadow-dom tests that pass on Mac. Would it make sense to enable shadow
> > DOM for GTK by default or is it still too early?
> 
> I think we can enable it in GTK+ now.

Thanks for the response. I just submitted a bug and will soon provide a patch (https://bugs.webkit.org/show_bug.cgi?id=158686).