WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 158736
WebRTC: Add media setup test using the legacy callback APIs
https://bugs.webkit.org/show_bug.cgi?id=158736
Summary
WebRTC: Add media setup test using the legacy callback APIs
Adam Bergkvist
Reported
2016-06-14 07:35:19 PDT
Add a test that sets up media using the legacy callback based createOffer/Answer() and setLocal/RemoteDescription() methods [1]. [1]
https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#legacy-interface-extensions
Attachments
Proposed patch
(7.80 KB, patch)
2016-06-15 02:18 PDT
,
Adam Bergkvist
no flags
Details
Formatted Diff
Diff
Updated patch
(7.77 KB, patch)
2016-06-15 02:23 PDT
,
Adam Bergkvist
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adam Bergkvist
Comment 1
2016-06-15 02:18:42 PDT
Created
attachment 281347
[details]
Proposed patch
Adam Bergkvist
Comment 2
2016-06-15 02:20:40 PDT
Comment on
attachment 281347
[details]
Proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=281347&action=review
> LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-callbacks-single-dialog.html:1 > +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
Will fix old doctype in next iteration.
Adam Bergkvist
Comment 3
2016-06-15 02:23:14 PDT
Created
attachment 281348
[details]
Updated patch
Adam Bergkvist
Comment 4
2016-06-15 14:05:13 PDT
Comment on
attachment 281348
[details]
Updated patch Thanks for reviewing
WebKit Commit Bot
Comment 5
2016-06-15 14:27:07 PDT
Comment on
attachment 281348
[details]
Updated patch Clearing flags on attachment: 281348 Committed
r202108
: <
http://trac.webkit.org/changeset/202108
>
WebKit Commit Bot
Comment 6
2016-06-15 14:27:10 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug