Bug 158691 - WebRTC: Add media setup test where media is set up in one direction at a time
Summary: WebRTC: Add media setup test where media is set up in one direction at a time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 143211
  Show dependency treegraph
 
Reported: 2016-06-13 05:26 PDT by Adam Bergkvist
Modified: 2016-06-14 08:11 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch (16.01 KB, patch)
2016-06-14 02:29 PDT, Adam Bergkvist
eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (16.00 KB, patch)
2016-06-14 06:44 PDT, Adam Bergkvist
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Bergkvist 2016-06-13 05:26:35 PDT
Setting up media in one direction at a time means completing a first offer/answer dialog with unidirectional media, and then sending an updated offer to add media in the other direction.
Comment 1 Adam Bergkvist 2016-06-14 02:29:33 PDT
Created attachment 281248 [details]
Proposed patch
Comment 2 Eric Carlson 2016-06-14 05:59:08 PDT
Comment on attachment 281248 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281248&action=review

> LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html:12
> +            description("Test setting up media between two RTCPeerConnection instances with one single SDP dialog.");

Nit: "... with one single ..." -> "... with a single ..."

> LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html:112
> +                testPassed("Frist offer/answer dialog completed")

Nit: "Frist" -> "First"
Comment 3 Adam Bergkvist 2016-06-14 06:44:18 PDT
Created attachment 281254 [details]
Patch for landing
Comment 4 Adam Bergkvist 2016-06-14 06:45:43 PDT
(In reply to comment #2)
> Comment on attachment 281248 [details]
> Proposed patch

Thanks for reviewing Eric. 'Patch for landing' submitted.

> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281248&action=review
> 
> > LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html:12
> > +            description("Test setting up media between two RTCPeerConnection instances with one single SDP dialog.");
> 
> Nit: "... with one single ..." -> "... with a single ..."

Fixed.

> > LayoutTests/fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html:112
> > +                testPassed("Frist offer/answer dialog completed")
> 
> Nit: "Frist" -> "First"

Fixed.
Comment 5 WebKit Commit Bot 2016-06-14 08:11:43 PDT
Comment on attachment 281254 [details]
Patch for landing

Clearing flags on attachment: 281254

Committed r202043: <http://trac.webkit.org/changeset/202043>
Comment 6 WebKit Commit Bot 2016-06-14 08:11:47 PDT
All reviewed patches have been landed.  Closing bug.