RESOLVED FIXED Bug 158688
WebRTC: Imlement MediaEndpointPeerConnection::replaceTrack() 
https://bugs.webkit.org/show_bug.cgi?id=158688
Summary WebRTC: Imlement MediaEndpointPeerConnection::replaceTrack()
Adam Bergkvist
Reported 2016-06-13 04:43:32 PDT
A call to RTCRtpSender.replaceTrack() [1] eventually ends up in MediaEndpointPeerConnection::replaceTrack(). [1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcrtpsender-replacetrack
Attachments
Proposed patch (18.47 KB, patch)
2016-06-13 04:58 PDT, Adam Bergkvist 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (18.49 KB, patch)
2016-06-13 14:35 PDT, Adam Bergkvist 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Bergkvist
Comment 1 2016-06-13 04:58:37 PDT
Created attachment 281166 [details] Proposed patch
Eric Carlson
Comment 2 2016-06-13 08:08:51 PDT
Comment on attachment 281166 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=281166&action=review > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:634 > + const String& mid = transceiver->mid(); Is it worth ASSERTing transceiver here?
Adam Bergkvist
Comment 3 2016-06-13 12:18:14 PDT
(In reply to comment #2) > Comment on attachment 281166 [details] > Proposed patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281166&action=review > > > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:634 > > + const String& mid = transceiver->mid(); > > Is it worth ASSERTing transceiver here? We can do that to emphasize that it should always be found or something is broken.
Adam Bergkvist
Comment 4 2016-06-13 14:35:02 PDT
Created attachment 281203 [details] Patch for landing
Adam Bergkvist
Comment 5 2016-06-13 22:39:57 PDT
Comment on attachment 281203 [details] Patch for landing Thanks for reviewing Eric!
WebKit Commit Bot
Comment 6 2016-06-13 23:02:53 PDT
Comment on attachment 281203 [details] Patch for landing Clearing flags on attachment: 281203 Committed r202026: <http://trac.webkit.org/changeset/202026>
Note You need to log in before you can comment on or make changes to this bug.