Bug 158688 - WebRTC: Imlement MediaEndpointPeerConnection::replaceTrack()
Summary: WebRTC: Imlement MediaEndpointPeerConnection::replaceTrack()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 143211
  Show dependency tree / graph
 
Reported: 2016-06-13 04:43 PDT by Adam Bergkvist
Modified: 2016-06-14 02:05 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (18.47 KB, patch)
2016-06-13 04:58 PDT, Adam Bergkvist 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (18.49 KB, patch)
2016-06-13 14:35 PDT, Adam Bergkvist 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Bergkvist 2016-06-13 04:43:32 PDT 
A call to RTCRtpSender.replaceTrack() [1] eventually ends up in MediaEndpointPeerConnection::replaceTrack().

[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcrtpsender-replacetrack
Comment 1 Adam Bergkvist 2016-06-13 04:58:37 PDT 
Created attachment 281166 [details]
Proposed patch
Comment 2 Eric Carlson 2016-06-13 08:08:51 PDT 
Comment on attachment 281166 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281166&action=review

> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:634
> +    const String& mid = transceiver->mid();

Is it worth ASSERTing transceiver here?
Comment 3 Adam Bergkvist 2016-06-13 12:18:14 PDT 
(In reply to comment #2)
> Comment on attachment 281166 [details]
> Proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281166&action=review
> 
> > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:634
> > +    const String& mid = transceiver->mid();
> 
> Is it worth ASSERTing transceiver here?

We can do that to emphasize that it should always be found or something is broken.
Comment 4 Adam Bergkvist 2016-06-13 14:35:02 PDT 
Created attachment 281203 [details]
Patch for landing
Comment 5 Adam Bergkvist 2016-06-13 22:39:57 PDT 
Comment on attachment 281203 [details]
Patch for landing

Thanks for reviewing Eric!
Comment 6 WebKit Commit Bot 2016-06-13 23:02:53 PDT 
Comment on attachment 281203 [details]
Patch for landing

Clearing flags on attachment: 281203

Committed r202026: <http://trac.webkit.org/changeset/202026>