Bug 158620 - WebRTC: Add media setup test with complete offer/answer dialog
Summary: WebRTC: Add media setup test with complete offer/answer dialog
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 143211
  Show dependency treegraph
 
Reported: 2016-06-10 10:05 PDT by Adam Bergkvist
Modified: 2016-06-13 12:37 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (9.85 KB, patch)
2016-06-10 10:27 PDT, Adam Bergkvist
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (629.38 KB, application/zip)
2016-06-10 11:33 PDT, Build Bot
no flags Details
Updated patch (9.81 KB, patch)
2016-06-13 03:58 PDT, Adam Bergkvist
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Bergkvist 2016-06-10 10:05:55 PDT
Add test that sets up media with a single SDP offer/answer dialog.
Comment 1 Adam Bergkvist 2016-06-10 10:27:28 PDT
Created attachment 281015 [details]
Proposed patch
Comment 2 Build Bot 2016-06-10 11:33:43 PDT
Comment on attachment 281015 [details]
Proposed patch

Attachment 281015 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1479623

New failing tests:
fast/scrolling/ios/scrollTo-at-page-load.html
Comment 3 Build Bot 2016-06-10 11:33:46 PDT
Created attachment 281020 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 4 Adam Bergkvist 2016-06-13 03:58:54 PDT
Created attachment 281164 [details]
Updated patch
Comment 5 Adam Bergkvist 2016-06-13 05:01:13 PDT
Eric, I've tried to apply your review comments from https://bugs.webkit.org/show_bug.cgi?id=158621 to this test as well.
Comment 6 Eric Carlson 2016-06-13 07:55:49 PDT
(In reply to comment #5)
> Eric, I've tried to apply your review comments from
> https://bugs.webkit.org/show_bug.cgi?id=158621 to this test as well.

Thanks Adam!
Comment 7 Adam Bergkvist 2016-06-13 12:14:41 PDT
Comment on attachment 281164 [details]
Updated patch

Thanks for reviewing!
Comment 8 WebKit Commit Bot 2016-06-13 12:37:01 PDT
Comment on attachment 281164 [details]
Updated patch

Clearing flags on attachment: 281164

Committed r201998: <http://trac.webkit.org/changeset/201998>
Comment 9 WebKit Commit Bot 2016-06-13 12:37:05 PDT
All reviewed patches have been landed.  Closing bug.