Bug 158566 - WebRTC: Implement MediaEndpointPeerConnection::createAnswer()
Summary: WebRTC: Implement MediaEndpointPeerConnection::createAnswer()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 143211
  Show dependency tree / graph
 
Reported: 2016-06-09 07:45 PDT by Adam Bergkvist
Modified: 2016-06-13 22:42 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (14.02 KB, patch)
2016-06-09 08:04 PDT, Adam Bergkvist 		no flags Details | Formatted Diff | Diff
Updated patch (14.62 KB, patch)
2016-06-09 08:44 PDT, Adam Bergkvist 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (14.73 KB, patch)
2016-06-09 22:29 PDT, Adam Bergkvist 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Bergkvist 2016-06-09 07:45:45 PDT 
Add the MediaEndpointPeerConnection implementation of RTCPeerConnection.createAnswer [1]. createAnswer() creats a 'reply' to an remote offer set with setRemoteDescription(), completes the offer/answer dialog and brings the RTCPeerConnection back to the 'stable' signaling state.
Comment 1 Adam Bergkvist 2016-06-09 08:04:11 PDT 
Created attachment 280921 [details]
Proposed patch
Comment 2 Adam Bergkvist 2016-06-09 08:44:56 PDT 
Created attachment 280923 [details]
Updated patch

Skip test on mac port
Comment 3 Eric Carlson 2016-06-09 11:06:28 PDT 
Comment on attachment 280923 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280923&action=review

> Source/WebCore/ChangeLog:9
> +        createAnswer() creats a 'reply' to an remote offer set with setRemoteDescription(),

Nit: "creats" -> "creates"
Comment 4 Adam Bergkvist 2016-06-09 22:29:39 PDT 
Created attachment 280996 [details]
Patch for landing

Fixed change log typo. Thanks for reviewing Eric.
Comment 5 WebKit Commit Bot 2016-06-10 02:13:36 PDT 
Comment on attachment 280996 [details]
Patch for landing

Clearing flags on attachment: 280996

Committed r201920: <http://trac.webkit.org/changeset/201920>