Bug 158286 - Vertical writing mode divs don't relayout when their horizontal writing mode containing block changes height
Summary: Vertical writing mode divs don't relayout when their horizontal writing mode ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-01 17:19 PDT by Myles C. Maxfield
Modified: 2023-03-20 12:34 PDT (History)
3 users (show)

See Also:

Attachments
Actual result (288 bytes, text/html)
2016-06-01 17:19 PDT, Myles C. Maxfield 		no flags Details
Expected result (178 bytes, text/html)
2016-06-01 17:20 PDT, Myles C. Maxfield 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-06-01 17:19:54 PDT 
Created attachment 280281 [details]
Actual result

See the attached test.
Comment 1 Myles C. Maxfield 2016-06-01 17:20:11 PDT 
Created attachment 280282 [details]
Expected result
Comment 2 Myles C. Maxfield 2016-06-01 18:25:09 PDT 
RenderBox::perpendicularContainingBlockLogicalHeight() needs to perform the same treatment to the element which dictates the return value for containingBlock()->availableLogicalHeight() as in https://bugs.webkit.org/show_bug.cgi?id=158245
Comment 3 Ahmad Saleem 2023-03-20 12:27:39 PDT 
I am not able to reproduce the bug, both "Actual" and "Expected" are same and matching with Chrome Canary 113 in behavior.

Can we get rid of FIXME, if it is working fine now?

@Alan & @Myles - any input - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBox.cpp#2277 or I am reproducing this bug wrong or missed something?
Comment 4 Ahmad Saleem 2023-03-20 12:34:03 PDT 
(In reply to Ahmad Saleem from comment #3)
> I am not able to reproduce the bug, both "Actual" and "Expected" are same
> and matching with Chrome Canary 113 in behavior.
> 
> Can we get rid of FIXME, if it is working fine now?
> 
> @Alan & @Myles - any input -
> https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBox.
> cpp#2277 or I am reproducing this bug wrong or missed something?

I came across this FIXME, while trying to look into this Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/fed69992a9de1357f400379e13fa87dbeaae14b4 and noticing that we have not imported this test case and don't have similar code.