Bug 158203 - WebRTC: Update MediaEndpointPeerConnection::createOffer() to use the transceiver set
Summary: WebRTC: Update MediaEndpointPeerConnection::createOffer() to use the transcei...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 143211
  Show dependency tree / graph
 
Reported: 2016-05-30 07:05 PDT by Adam Bergkvist
Modified: 2016-06-06 23:07 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (24.20 KB, patch)
2016-06-02 14:16 PDT, Adam Bergkvist 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (24.15 KB, patch)
2016-06-06 10:21 PDT, Adam Bergkvist 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Bergkvist 2016-05-30 07:05:13 PDT 
Currently MediaEndpointPeerConnection::createOffer() uses the sender set (RTCRtpSender objects) to create an offer, but the latest WebRTC 1.0 specifications [1][2] describe this process in terms of the RTCRtpTranceiver object.

[1] http://rtcweb-wg.github.io/jsep/
[2] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.htm
Comment 1 Adam Bergkvist 2016-06-02 14:16:11 PDT 
Created attachment 280366 [details]
Proposed patch
Comment 2 Eric Carlson 2016-06-03 08:09:18 PDT 
Comment on attachment 280366 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280366&action=review

> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:110
> +    unsigned m_sdpAnswerSessionVersion { 0 };

Nit: This isn't used (yet?).
Comment 3 Adam Bergkvist 2016-06-03 10:52:47 PDT 
Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:110
> > +    unsigned m_sdpAnswerSessionVersion { 0 };
> 
> Nit: This isn't used (yet?).

True. I can remove it before committing.
Comment 4 Adam Bergkvist 2016-06-06 10:21:39 PDT 
Created attachment 280605 [details]
Patch for landing
Comment 5 Adam Bergkvist 2016-06-06 14:16:52 PDT 
Comment on attachment 280605 [details]
Patch for landing

Thanks for reviewing Eric!
Comment 6 WebKit Commit Bot 2016-06-06 14:39:33 PDT 
Comment on attachment 280605 [details]
Patch for landing

Clearing flags on attachment: 280605

Committed r201728: <http://trac.webkit.org/changeset/201728>