Bug 158203 – WebRTC: Update MediaEndpointPeerConnection::createOffer() to use the transceiver set

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Adam Bergkvist]

Currently MediaEndpointPeerConnection::createOffer() uses the sender set (RTCRtpSender objects) to create an offer, but the latest WebRTC 1.0 specifications [1][2] describe this process in terms of the RTCRtpTranceiver object.

[1] http://rtcweb-wg.github.io/jsep/
[2] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.htm

[Adam Bergkvist]

Created attachment 280366 [details]
Proposed patch

[Eric Carlson]

Comment on attachment 280366 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280366&action=review

> Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:110
> +    unsigned m_sdpAnswerSessionVersion { 0 };

Nit: This isn't used (yet?).

[Adam Bergkvist]

Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h:110
> > +    unsigned m_sdpAnswerSessionVersion { 0 };
> 
> Nit: This isn't used (yet?).

True. I can remove it before committing.

[Adam Bergkvist]

Created attachment 280605 [details]
Patch for landing

[Adam Bergkvist]

Comment on attachment 280605 [details]
Patch for landing

Thanks for reviewing Eric!

[WebKit Commit Bot]

Comment on attachment 280605 [details]
Patch for landing

Clearing flags on attachment: 280605

Committed r201728: <http://trac.webkit.org/changeset/201728>