Bug 158196 – Transition various Task/Function queues from std::function to NoncopyableFunction

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Transition various Task/Function queues from std::function to NoncopyableFunction

Another smaller step towards https://bugs.webkit.org/show_bug.cgi?id=158173

[Brady Eidson]

Created attachment 280070 [details]
Patch

[Chris Dumez]

Patch does not apply

[Chris Dumez]

Comment on attachment 280070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280070&action=review

R=me with a couple of comments

> Source/WebCore/html/HTMLMediaElement.cpp:3997
> +    NoncopyableFunction<void()> task = [this, protectedThis = Ref<Element>(*this)] {

Could use "auto task = ..."

> Source/WebCore/page/FrameView.cpp:3150
> +    queue.swap(m_postLayoutCallbackQueue);

I thought we preferred to use WTFMove() for these sort of things these days:
Vector<NoncopyableFunction<void()>> queue = WTFMove(m_postLayoutCallbackQueue);

> Source/WebCore/platform/GenericTaskQueue.h:87
>      void enqueueTask(TaskFunction task)

Should be a TaskFunction&& ?

[Brady Eidson]

Created attachment 280073 [details]
Patch

[WebKit Commit Bot]

Attachment 280073 [details] did not pass style-queue:


ERROR: Source/WebCore/style/StyleTreeResolver.cpp:524:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:526:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:530:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.h:113:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 280073 [details]
Patch

Clearing flags on attachment: 280073

Committed r201497: <http://trac.webkit.org/changeset/201497>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.