Bug 158173 - Clean up all C++ lambdas passed to methods other than callOnMainThread
Summary: Clean up all C++ lambdas passed to methods other than callOnMainThread
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 158185 158187 158196
Blocks:
  Show dependency treegraph
 
Reported: 2016-05-27 17:01 PDT by Brady Eidson
Modified: 2016-05-29 22:16 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-05-27 17:01:20 PDT
Clean up all C++ lambdas passed to dispatch() methods

Now that we have C++14 we can make sure we don't do unnecessary copies of captured variables, as well as initialize things like protectors inside of the capture list.

By going through all of them we can probably also fix some thread safety issues.

I plan to grep through all of Source using:
grep -rn '\[.\+\]\s*\((.*)\)\?\s*{\s*$' .
Comment 1 Brady Eidson 2016-05-27 17:02:41 PDT
I meant:
grep -rn '\[.\+\]\s*\((.*)\)\?\s*{\s*$' . | grep -v callOnMainThread

Because I don't want to conflict with https://bugs.webkit.org/show_bug.cgi?id=158166