Bug 158132 – EventHandler finds incorrect scrollable container.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

Created attachment 279914 [details]
Test reduction

1. Load test page
2. Scroll to the bottom
3. Scroll horizontally
Expected result: bottom container scrolls
Actual result: top container scrolls (8 out of 10)

[alan]

rdar://problem/26423126

[alan]

Created attachment 279919 [details]
Patch

[Brent Fulgham]

Comment on attachment 279919 [details]
Patch

Zalan and I reviewed this in person. I agree with his change.

[alan]

Created attachment 280000 [details]
Patch

[alan]

Created attachment 280001 [details]
Patch

[Brent Fulgham]

Comment on attachment 280001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280001&action=review

r=me

> Source/WebCore/page/mac/EventHandlerMac.mm:820
> +                    || ((deltaX > 0) && !scrollableArea->scrolledToLeft()) || ((deltaX < 0) && !scrollableArea->scrolledToRight())) {

Ugh! Thank you for fixing this!

[Build Bot]

Comment on attachment 280001 [details]
Patch

Attachment 280001 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1393488

New failing tests:
fast/scrolling/scroll-container-horizontally.html

[Build Bot]

Created attachment 280004 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Brent Fulgham]

(In reply to comment #7)
> Comment on attachment 280001 [details]
> Patch
> 
> Attachment 280001 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.webkit.org/results/1393488
> 
> New failing tests:
> fast/scrolling/scroll-container-horizontally.html

The Scroll trigger stuff doesn't work on WK1, so you should skip this test in WK1. I should have caught that during review. :-( Sorry!

[Build Bot]

Comment on attachment 280001 [details]
Patch

Attachment 280001 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1393492

New failing tests:
fast/scrolling/scroll-container-horizontally.html

[Build Bot]

Created attachment 280007 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Brent Fulgham]

(In reply to comment #10)
> Comment on attachment 280001 [details]
> Patch
> 
> Attachment 280001 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/1393492
> 
> New failing tests:
> fast/scrolling/scroll-container-horizontally.html

I think that's true for iOS as well. Check TestExpectations -- I think we turn off wheel even tests because we don't automatically treat wheel events as swipe gestures on iOS.

[alan]

ok. I'll skip it on WK1 and iOS.

[Build Bot]

Comment on attachment 280001 [details]
Patch

Attachment 280001 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1393502

New failing tests:
fast/scrolling/scroll-container-horizontally.html

[Build Bot]

Created attachment 280009 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[alan]

Created attachment 280010 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 280010 [details]
Patch

Clearing flags on attachment: 280010

Committed r201476: <http://trac.webkit.org/changeset/201476>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

The LayoutTest added with this change if frequently timing out. Filed https://bugs.webkit.org/show_bug.cgi?id=158237