Bug 158036 - We can cache lookups to JSScope::abstractResolve inside CodeBlock::finishCreation
Summary: We can cache lookups to JSScope::abstractResolve inside CodeBlock::finishCrea...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on: 158238
Blocks:
  Show dependency tree / graph
 
Reported: 2016-05-24 12:18 PDT by Saam Barati
Modified: 2016-05-31 15:03 PDT (History)
11 users (show)

See Also:

Attachments
patch (7.40 KB, patch)
2016-05-24 13:22 PDT, Saam Barati 		ggaren: review+
Details | Formatted Diff | Diff
patch for landing (7.33 KB, patch)
2016-05-24 13:40 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-05-24 12:18:48 PDT 
...
Comment 1 Saam Barati 2016-05-24 13:22:26 PDT 
Created attachment 279697 [details]
patch
Comment 2 Geoffrey Garen 2016-05-24 13:28:56 PDT 
Comment on attachment 279697 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279697&action=review

r=me

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1871
> +    bool isEmptyValue() const { return m_depth == std::numeric_limits<size_t>::max(); }

We usually call this isNull().

Can we use nullptr in m_impl as null instead? That's a clearer null value.
Comment 3 Saam Barati 2016-05-24 13:30:57 PDT 
Comment on attachment 279697 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279697&action=review

>> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1871
>> +    bool isEmptyValue() const { return m_depth == std::numeric_limits<size_t>::max(); }
> 
> We usually call this isNull().
> 
> Can we use nullptr in m_impl as null instead? That's a clearer null value.

Will do.
Comment 4 Saam Barati 2016-05-24 13:40:52 PDT 
Created attachment 279699 [details]
patch for landing
Comment 5 WebKit Commit Bot 2016-05-24 15:27:12 PDT 
Comment on attachment 279699 [details]
patch for landing

Clearing flags on attachment: 279699

Committed r201359: <http://trac.webkit.org/changeset/201359>
Comment 6 WebKit Commit Bot 2016-05-24 15:27:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Commit Bot 2016-05-31 15:03:00 PDT 
Re-opened since this is blocked by bug 158238