...
Created attachment 279697 [details] patch
Comment on attachment 279697 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=279697&action=review r=me > Source/JavaScriptCore/bytecode/CodeBlock.cpp:1871 > + bool isEmptyValue() const { return m_depth == std::numeric_limits<size_t>::max(); } We usually call this isNull(). Can we use nullptr in m_impl as null instead? That's a clearer null value.
Comment on attachment 279697 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=279697&action=review >> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1871 >> + bool isEmptyValue() const { return m_depth == std::numeric_limits<size_t>::max(); } > > We usually call this isNull(). > > Can we use nullptr in m_impl as null instead? That's a clearer null value. Will do.
Created attachment 279699 [details] patch for landing
Comment on attachment 279699 [details] patch for landing Clearing flags on attachment: 279699 Committed r201359: <http://trac.webkit.org/changeset/201359>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by bug 158238