Bug 158007 - Swap search field's cancel and result button for RTL content.
Summary: Swap search field's cancel and result button for RTL content.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
: 51499 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-05-23 19:05 PDT by zalan
Modified: 2016-08-07 20:44 PDT (History)
6 users (show)

See Also:

Attachments
Patch (23.93 KB, patch)
2016-05-23 19:08 PDT, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (1.00 MB, application/zip)
2016-05-23 19:49 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.08 MB, application/zip)
2016-05-23 20:00 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (843.13 KB, application/zip)
2016-05-23 20:01 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.59 MB, application/zip)
2016-05-23 20:09 PDT, Build Bot 		no flags Details
Patch (35.13 KB, patch)
2016-05-24 12:01 PDT, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (881.31 KB, application/zip)
2016-05-24 12:28 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.05 MB, application/zip)
2016-05-24 12:32 PDT, Build Bot 		no flags Details
Patch (40.07 KB, patch)
2016-05-24 12:56 PDT, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (835.51 KB, application/zip)
2016-05-24 13:35 PDT, Build Bot 		no flags Details
Patch (43.65 KB, patch)
2016-05-24 13:51 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (29.36 KB, patch)
2016-05-24 15:16 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (11) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-05-23 19:05:00 PDT 
rdar://problem/25346475
Comment 1 zalan 2016-05-23 19:08:41 PDT 
Created attachment 279610 [details]
Patch
Comment 2 Build Bot 2016-05-23 19:49:46 PDT 
Comment on attachment 279610 [details]
Patch

Attachment 279610 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1372326

New failing tests:
transitions/default-timing-function.html
fast/css/text-overflow-input.html
fast/forms/search-rtl.html
Comment 3 Build Bot 2016-05-23 19:49:49 PDT 
Created attachment 279612 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-05-23 20:00:45 PDT 
Comment on attachment 279610 [details]
Patch

Attachment 279610 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1372329

New failing tests:
fast/css/text-overflow-input.html
fast/forms/search-rtl.html
Comment 5 Build Bot 2016-05-23 20:00:47 PDT 
Created attachment 279615 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-05-23 20:01:55 PDT 
Comment on attachment 279610 [details]
Patch

Attachment 279610 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1372322

New failing tests:
fast/forms/search-input-rtl.html
fast/css/text-overflow-input.html
fast/forms/search-rtl.html
Comment 7 Build Bot 2016-05-23 20:01:58 PDT 
Created attachment 279616 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 8 Build Bot 2016-05-23 20:09:20 PDT 
Comment on attachment 279610 [details]
Patch

Attachment 279610 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1372332

New failing tests:
fast/css/text-overflow-input.html
fast/forms/search-rtl.html
Comment 9 Build Bot 2016-05-23 20:09:23 PDT 
Created attachment 279617 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 zalan 2016-05-24 12:01:36 PDT 
Created attachment 279680 [details]
Patch
Comment 11 Build Bot 2016-05-24 12:28:54 PDT 
Comment on attachment 279680 [details]
Patch

Attachment 279680 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1376171

New failing tests:
fast/forms/search-rtl.html
Comment 12 Build Bot 2016-05-24 12:28:57 PDT 
Created attachment 279686 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 13 Build Bot 2016-05-24 12:32:27 PDT 
Comment on attachment 279680 [details]
Patch

Attachment 279680 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1376174

New failing tests:
fast/forms/search-rtl.html
Comment 14 Build Bot 2016-05-24 12:32:31 PDT 
Created attachment 279688 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 15 zalan 2016-05-24 12:56:39 PDT 
Created attachment 279693 [details]
Patch
Comment 16 Build Bot 2016-05-24 13:35:55 PDT 
Comment on attachment 279693 [details]
Patch

Attachment 279693 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1376398

New failing tests:
fast/forms/search-input-rtl.html
Comment 17 Build Bot 2016-05-24 13:35:59 PDT 
Created attachment 279698 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 18 zalan 2016-05-24 13:51:41 PDT 
Created attachment 279700 [details]
Patch
Comment 19 zalan 2016-05-24 15:16:08 PDT 
Created attachment 279710 [details]
Patch
Comment 20 WebKit Commit Bot 2016-05-25 12:40:26 PDT 
Comment on attachment 279710 [details]
Patch

Clearing flags on attachment: 279710

Committed r201397: <http://trac.webkit.org/changeset/201397>
Comment 21 WebKit Commit Bot 2016-05-25 12:40:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 22 Kent Tamura 2016-08-07 20:44:08 PDT 
*** Bug 51499 has been marked as a duplicate of this bug. ***