WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
157642
Add machine-readable results for JSC API tests to the Buildbot log
https://bugs.webkit.org/show_bug.cgi?id=157642
Summary
Add machine-readable results for JSC API tests to the Buildbot log
Srinivasan Vijayaraghavan
Reported
2016-05-12 15:44:04 PDT
Add machine-readable results for JSC API tests to the Buildbot log
Attachments
Patch
(3.43 KB, patch)
2016-05-12 15:47 PDT
,
Srinivasan Vijayaraghavan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Srinivasan Vijayaraghavan
Comment 1
2016-05-12 15:47:22 PDT
Created
attachment 278772
[details]
Patch
Srinivasan Vijayaraghavan
Comment 2
2016-05-12 15:52:04 PDT
Comment on
attachment 278772
[details]
Patch I abstracted out the function that writes JSON to the file. This minimizes the number of conditionals (i.e. checking whether --json-output is specified, which is indicated by $jsonFileName being defined) and also reduces the amount of refactoring. Open to suggestions on how to do this better.
Geoffrey Garen
Comment 3
2016-05-16 11:49:45 PDT
Comment on
attachment 278772
[details]
Patch r=me
Geoffrey Garen
Comment 4
2016-05-16 11:50:01 PDT
Would be nice to hook up crash logs to the bot results too.
WebKit Commit Bot
Comment 5
2016-05-16 11:56:31 PDT
Comment on
attachment 278772
[details]
Patch Clearing flags on attachment: 278772 Committed
r200956
: <
http://trac.webkit.org/changeset/200956
>
WebKit Commit Bot
Comment 6
2016-05-16 11:56:36 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug