Bug 157270 – Add fail-fast option to run-javascriptcore-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Srinivasan Vijayaraghavan]

Add fail-fast option to run-javascriptcore-tests

[Srinivasan Vijayaraghavan]

Created attachment 277912 [details]
Patch

[Geoffrey Garen]

Comment on attachment 277912 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277912&action=review

r=me

> Tools/Scripts/run-javascriptcore-tests:211
> +    if ($failFast) {
> +        exit exitStatus($testapiResult) if $testapiResult;

Since we have two conditions here, I think it's clearer to merge them into one if statement:

if ($testapiResult && $failFast) {
    exit...
}

[Srinivasan Vijayaraghavan]

Created attachment 277915 [details]
Patch

[Srinivasan Vijayaraghavan]

(In reply to comment #2)
> Comment on attachment 277912 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=277912&action=review
> 
> r=me
> 
> > Tools/Scripts/run-javascriptcore-tests:211
> > +    if ($failFast) {
> > +        exit exitStatus($testapiResult) if $testapiResult;
> 
> Since we have two conditions here, I think it's clearer to merge them into
> one if statement:
> 
> if ($testapiResult && $failFast) {
>     exit...
> }

Thanks! I've fixed this.

[Srinivasan Vijayaraghavan]

Created attachment 277928 [details]
Patch

[Ryan Haddad]

Comment on attachment 277928 [details]
Patch

mac-debug failures seem to be unrelated, marking cq+

[WebKit Commit Bot]

Comment on attachment 277928 [details]
Patch

Clearing flags on attachment: 277928

Committed r200339: <http://trac.webkit.org/changeset/200339>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.