Bug 157631 - Optimize layer repaint rects to compute less often
Summary: Optimize layer repaint rects to compute less often
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
: 156506 (view as bug list)
Depends on:
Blocks: 158079
  Show dependency tree / graph
 
Reported: 2016-05-12 11:42 PDT by Dave Hyatt
Modified: 2016-08-04 11:36 PDT (History)
8 users (show)

See Also:

Attachments
Patch (26.34 KB, patch)
2016-05-12 11:43 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (28.65 KB, patch)
2016-05-12 13:03 PDT, Dave Hyatt 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (965.52 KB, application/zip)
2016-05-12 14:20 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (1.42 MB, application/zip)
2016-05-12 16:49 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (654.61 KB, application/zip)
2016-05-12 16:54 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews101 for mac-yosemite (1.72 MB, application/zip)
2016-05-13 01:23 PDT, Build Bot 		no flags Details
Patch (33.55 KB, patch)
2016-05-13 09:48 PDT, Dave Hyatt 		zalan: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-yosemite (364.25 KB, application/zip)
2016-05-13 10:34 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (758.90 KB, application/zip)
2016-05-13 10:40 PDT, Build Bot 		no flags Details
Patch (35.60 KB, patch)
2016-05-17 10:00 PDT, Dave Hyatt 		zalan: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-yosemite (432.18 KB, application/zip)
2016-05-17 10:43 PDT, Build Bot 		no flags Details
Patch (37.53 KB, patch)
2016-05-17 13:37 PDT, Dave Hyatt 		zalan: review+
Details | Formatted Diff | Diff
Show Obsolete (11) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-05-12 11:42:26 PDT 
Optimize layer repaint rects to compute less often
Comment 1 Dave Hyatt 2016-05-12 11:43:23 PDT 
Created attachment 278741 [details]
Patch
Comment 2 Dave Hyatt 2016-05-12 13:03:00 PDT 
Created attachment 278750 [details]
Patch
Comment 3 WebKit Commit Bot 2016-05-12 13:46:01 PDT 
Attachment 278750 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderLayer.cpp:861:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderLayer.cpp:862:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Build Bot 2016-05-12 14:20:46 PDT 
Comment on attachment 278750 [details]
Patch

Attachment 278750 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1311147

New failing tests:
svg/custom/svg-percent-scale.html
svg/custom/svg-percent-scale-vonly.html
fast/repaint/percent-minheight-resize.html
fast/repaint/reflection-table-layout.html
fast/events/overflow-scroll-fake-mouse-move.html
fast/regions/repaint/invalid-region-repaint-crash.html
svg/custom/svg-percent-scale-block.html
fast/regions/repaint/element-outflow-static-from-inflow-fixed.html
Comment 5 Build Bot 2016-05-12 14:20:50 PDT 
Created attachment 278760 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-05-12 16:49:30 PDT 
Comment on attachment 278750 [details]
Patch

Attachment 278750 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1311753

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-05-12 16:49:33 PDT 
Created attachment 278781 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-05-12 16:54:07 PDT 
Comment on attachment 278750 [details]
Patch

Attachment 278750 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1311782

New failing tests:
fast/regions/repaint/invalid-region-repaint-crash.html
svg/custom/svg-percent-scale-vonly.html
svg/custom/svg-percent-scale.html
svg/custom/svg-percent-scale-block.html
fast/regions/repaint/element-outflow-static-from-inflow-fixed.html
Comment 9 Build Bot 2016-05-12 16:54:10 PDT 
Created attachment 278782 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 10 Build Bot 2016-05-13 01:23:13 PDT 
Comment on attachment 278750 [details]
Patch

Attachment 278750 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1313714

New failing tests:
svg/custom/svg-percent-scale.html
svg/custom/svg-percent-scale-vonly.html
fast/repaint/percent-minheight-resize.html
fast/repaint/reflection-table-layout.html
fast/regions/repaint/invalid-region-repaint-crash.html
svg/custom/svg-percent-scale-block.html
fast/regions/repaint/element-outflow-static-from-inflow-fixed.html
Comment 11 Build Bot 2016-05-13 01:23:17 PDT 
Created attachment 278823 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 12 Dave Hyatt 2016-05-13 09:48:48 PDT 
Created attachment 278843 [details]
Patch
Comment 13 Build Bot 2016-05-13 10:34:39 PDT 
Comment on attachment 278843 [details]
Patch

Attachment 278843 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1315712

Number of test failures exceeded the failure limit.
Comment 14 Build Bot 2016-05-13 10:34:42 PDT 
Created attachment 278847 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 15 Build Bot 2016-05-13 10:40:03 PDT 
Comment on attachment 278843 [details]
Patch

Attachment 278843 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1315745

New failing tests:
fast/events/overflow-scroll-fake-mouse-move.html
Comment 16 Build Bot 2016-05-13 10:40:06 PDT 
Created attachment 278848 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 17 Dave Hyatt 2016-05-17 10:00:31 PDT 
Created attachment 279133 [details]
Patch
Comment 18 Build Bot 2016-05-17 10:43:44 PDT 
Comment on attachment 279133 [details]
Patch

Attachment 279133 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1337293

Number of test failures exceeded the failure limit.
Comment 19 Build Bot 2016-05-17 10:43:47 PDT 
Created attachment 279137 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 20 Dave Hyatt 2016-05-17 13:37:08 PDT 
Created attachment 279160 [details]
Patch
Comment 21 Dave Hyatt 2016-05-17 14:01:21 PDT 
Landed in r201040.
Comment 22 Jon Lee 2016-05-18 12:10:48 PDT 
*** Bug 156506 has been marked as a duplicate of this bug. ***
Comment 23 Jon Lee 2016-05-18 12:11:46 PDT 
<rdar://problem/20195675>
Comment 24 Nikita Vasilyev 2016-05-25 14:35:56 PDT 
This broke autocompletion popover in Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=158079#c3
Comment 25 BJ Burg 2016-05-30 13:09:46 PDT 
It also caused Data Grid resizing in Web Inspector to have artifacts:
https://bugs.webkit.org/show_bug.cgi?id=158165
Comment 26 Nikita Vasilyev 2016-08-03 14:34:19 PDT 
(In reply to comment #24)
> This broke autocompletion popover in Web Inspector.
> https://bugs.webkit.org/show_bug.cgi?id=158079#c3

(In reply to comment #25)
> It also caused Data Grid resizing in Web Inspector to have artifacts:
> https://bugs.webkit.org/show_bug.cgi?id=158165

These have been fixed elsewhere.
Comment 27 Simon Fraser (smfr) 2016-08-04 11:36:39 PDT 
This caused bug 160551.