WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
157447
Rename HitTestRequest DisallowShadowContent to DisallowUserAgentShadowContent
https://bugs.webkit.org/show_bug.cgi?id=157447
Summary
Rename HitTestRequest DisallowShadowContent to DisallowUserAgentShadowContent
Joseph Pecoraro
Reported
2016-05-06 21:54:58 PDT
* SUMMARY Rename HitTestRequest DisallowShadowContent to DisallowUserAgentShadowContent. See diagnosis in patch on
bug 157446
. HitTesting is intended to reach nodes inside Web Components shadow content. This property on the HitTestRequest is intended to avoid hit testing in UserAgent shadow content. Lets rename the enum value, and cascading methods for clarity.
Attachments
[PATCH] Proposed Fix
(32.33 KB, patch)
2016-05-06 21:56 PDT
,
Joseph Pecoraro
rniwa
: review+
joepeck
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2016-05-06 21:56:08 PDT
Created
attachment 278317
[details]
[PATCH] Proposed Fix
Joseph Pecoraro
Comment 2
2016-05-06 21:57:08 PDT
cq- there is one instance in WebKitAdditions that I'll want to change at the same time.
Joseph Pecoraro
Comment 3
2016-05-06 21:57:40 PDT
And this probably won't apply until
bug 157446
lands anyways.
Ryosuke Niwa
Comment 4
2016-05-06 22:10:37 PDT
Comment on
attachment 278317
[details]
[PATCH] Proposed Fix r=me assuming you add some change log description.
Joseph Pecoraro
Comment 5
2016-05-06 23:03:56 PDT
<
http://trac.webkit.org/changeset/200540
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug