Bug 157446 - Web Inspector: Inspect Element and Element Selection searching should work with Shadow DOM Nodes
Summary: Web Inspector: Inspect Element and Element Selection searching should work wi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-06 21:22 PDT by Joseph Pecoraro
Modified: 2016-05-06 22:51 PDT (History)
13 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (6.31 KB, patch)
2016-05-06 21:35 PDT, Joseph Pecoraro
rniwa: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-06 21:22:35 PDT
* SUMMARY
Inspect Element searching and selection should work with Shadow DOM Nodes.

* STEPS TO REPRODUCE
1. Open a page with Shadow DOM Nodes
2. Right Click and Inspect Element
  => Expected inner shadow element to be selected in Web Inspector DOM Tree, it is not
3. Enable Node Selection mode from inspector
4. Hover elements in a Shadow DOM
  => Expected inner shadow elements to be highlighted, they are not
5. Click to select an element in a Shadow DOM
  => Expected inner shadow element to be selected in Web Inspector DOM Tree, it is not
Comment 1 Joseph Pecoraro 2016-05-06 21:22:45 PDT
<rdar://problem/24688447>
Comment 2 Joseph Pecoraro 2016-05-06 21:35:15 PDT
Created attachment 278314 [details]
[PATCH] Proposed Fix
Comment 3 Ryosuke Niwa 2016-05-06 21:41:23 PDT
Comment on attachment 278314 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278314&action=review

> Source/WebCore/rendering/HitTestResult.cpp:135
>  void HitTestResult::setToNonShadowAncestor()

Please rename this to moveInnerNodeOutOfUserAgentShadowTree or something so that the semantics is clear.
Comment 4 Joseph Pecoraro 2016-05-06 22:46:41 PDT
> Please rename this to moveInnerNodeOutOfUserAgentShadowTree or something so
> that the semantics is clear.

Renaming will be handled by Bug 157447.
Comment 5 Joseph Pecoraro 2016-05-06 22:51:37 PDT
<http://trac.webkit.org/changeset/200539>